Source Facebook Marketing: don't fetch thumbnail_data_url if it's None

[grubberr]

What

Issue: #20345

How

Describe the solution

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)

• Secrets in the connector's spec are annotated with airbyte_secret

• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

• Code reviews completed

• Connector version has been incremented

  • Version has been bumped according to our Semantic Versioning for Connectors guidelines
  • Dockerfile has updated version

• Documentation updated

  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example

• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

[grubberr]

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4644133020
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4644133020
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             24      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              42      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/streams/patches.py                   22      2    91%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/source.py                            59      6    90%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/streams/base_streams.py             143     22    85%
source_facebook_marketing/streams/streams.py                  125     29    77%
-------------------------------------------------------------------------------
TOTAL                                                        1002     87    91%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/spec.py                              42      1    98%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/patches.py                   22      3    86%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/source.py                            59     22    63%
source_facebook_marketing/utils.py                             24      9    62%
source_facebook_marketing/streams/streams.py                  125     50    60%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                        1002    401    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 1432.08s (0:23:52) ==================

[bazarnov]

It's better to add unit test for the case. WDYT?

[grubberr]

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4655981907

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️