destination harness #25030
Merged
destination harness #25030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcowanpdx
reviewed
Apr 11, 2023
.../destination-harness/src/main/java/io/airbyte/integrations/destination_performance/Main.java
Show resolved
Hide resolved
jcowanpdx
reviewed
Apr 11, 2023
...n-harness/src/main/java/io/airbyte/integrations/destination_performance/PerformanceTest.java
Outdated
Show resolved
Hide resolved
…to rodi/destination-performance
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
davinchia
reviewed
May 15, 2023
...n-harness/src/main/java/io/airbyte/integrations/destination_performance/PerformanceTest.java
Outdated
Show resolved
Hide resolved
…s/README.md Co-authored-by: Davin Chia <davinchia@gmail.com>
davinchia
reviewed
May 15, 2023
...e2e-test/src/main/java/io/airbyte/integrations/destination/e2e_test/TestingDestinations.java
Outdated
Show resolved
Hide resolved
davinchia
reviewed
May 15, 2023
...n-harness/src/main/java/io/airbyte/integrations/destination_performance/PerformanceTest.java
Outdated
Show resolved
Hide resolved
davinchia
approved these changes
May 15, 2023
There was a problem hiding this comment.
Thanks @rodireich !
I mainly looked at the GHA set up and the PerformanceTest.java class. Most of my comments are readability and non-blocking. Let me know if you would like another review before you merge!
…java/io/airbyte/integrations/destination/e2e_test/TestingDestinations.java Co-authored-by: Davin Chia <davinchia@gmail.com>
|
Thanks for reviewing @davinchia and @ryankfu |
|
/connector-performance connector=connectors/destination-snowflake ref=rodi/destination-performance Note: The following
|
|
/connector-performance connector=connectors/destination-snowflake ref=rodi/destination-performance Note: The following
|
|
Thank you so much @ryankfu !! |
ryankfu
reviewed
May 16, 2023
| @@ -97,7 +98,7 @@ static String getDatasource(final String dataset, final String connector) throws | |||
| log.info("datasourceFilename {}", datasourceFilename); | |||
| try (final var reader = | |||
| new BufferedReader(new InputStreamReader(Objects.requireNonNull( | |||
| Thread.currentThread().getContextClassLoader().getResourceAsStream(datasourceFilename))))) { | |||
| Thread.currentThread().getContextClassLoader().getResourceAsStream(datasourceFilename)), StandardCharsets.UTF_8))) { | |||
There was a problem hiding this comment.
😆 I was just about to push this change up too, thanks for fixing this first
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
* destination harness * Automated Commit - Formatting Changes * refactor to support multiple connectors * better byte counting * Automated Change * fix main cp * harness type * harness type * harness type * harness type * harness type * harness type * harness type * speed up harness build * harness type * harness type * harness type * harness type * 1m catalog * 1m catalog * Automated Commit - Formatting Changes * 1m catalog * Automated Commit - Formatting Changes * 1m catalog * Automated Commit - Formatting Changes * 1m catalog * 1m catalog * Automated Commit - Formatting Changes * 1m catalog * Automated Commit - Formatting Changes * Automated Change * add some additional logging for debugging * test * test * debugging code * Automated Commit - Formatting Changes * debugging code * debugging code * debugging code * Automated Commit - Formatting Changes * Checkpoint: This is working!. * Automated Commit - Formatting Changes * Updates plumbing for Snowflake with static records - Working * Automated Commit - Formatting Changes * working 10m * Automated Commit - Formatting Changes * add destination datasource * Automated Commit - Formatting Changes * sanity * sanity * Delete 1m_catalog.json * sanity * Update airbyte-integrations/connectors-performance/destination-harness/README.md Co-authored-by: Davin Chia <davinchia@gmail.com> * sanity * Update airbyte-integrations/connectors/destination-e2e-test/src/main/java/io/airbyte/integrations/destination/e2e_test/TestingDestinations.java Co-authored-by: Davin Chia <davinchia@gmail.com> * Splits performance harness into separated methods * Automated Commit - Formatting Changes * Updates test description to force Github builds --------- Co-authored-by: rodireich <rodireich@users.noreply.github.com> Co-authored-by: Jeff Cowan (Airbyte) <4992320+jcowanpdx@users.noreply.github.com> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: davinchia <davinchia@users.noreply.github.com> Co-authored-by: ryankfu <ryan.fu@airbyte.io> Co-authored-by: ryankfu <ryankfu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds functionality for destination performance harness. It includes the ability to run a Github Actions comment that will be updated
How