Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Quickbooks: turn off advanced oauth + fix input date format #25045

Merged
merged 5 commits into from Apr 11, 2023

Conversation

davydov-d
Copy link
Collaborator

  • Because currently the Quickboox OAuth application is not public and is blocked, we can not use it in cloud, therefore need to disable the "Authenticate" button.
  • Update the docs
  • Fix the start_date input parameter format

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/quickbooks labels Apr 11, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 11, 2023

/test connector=connectors/source-quickbooks

🕑 connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4666759091

@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 11, 2023

/test connector=connectors/source-quickbooks

🕑 connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4666903241
✅ connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4666903241
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_quickbooks/__init__.py         3      0   100%
source_quickbooks/components.py      36      4    89%
source_quickbooks/source.py           4      1    75%
-----------------------------------------------------
TOTAL                                43      5    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 1.0.0.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:587: Backward compatibility tests are disabled for version 1.0.0.
================== 38 passed, 2 skipped in 465.58s (0:07:45) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 11, 2023

/publish connector=connectors/source-quickbooks

🕑 Publishing the following connectors:
connectors/source-quickbooks
https://github.com/airbytehq/airbyte/actions/runs/4667091218


Connector Did it publish? Were definitions generated?
connectors/source-quickbooks skipped

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 11, 2023

/publish connector=connectors/source-quickbooks

🕑 Publishing the following connectors:
connectors/source-quickbooks
https://github.com/airbytehq/airbyte/actions/runs/4667532398


Connector Did it publish? Were definitions generated?
connectors/source-quickbooks

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit d244b99 into master Apr 11, 2023
21 of 25 checks passed
@davydov-d davydov-d deleted the ddavydov/#23498-source-quickbooks-fix-date-format branch April 11, 2023 13:31
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…irbytehq#25045)

* #23498 source quickbooks: turn off advanced oauth + fix input date format

* #23498 source quickbooks: upd doc

* #23498 source quickbooks: major update

* Automated Change

* auto-bump connector version

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/quickbooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants