Source Mixpanel: added HttpAvailabilityStrategy and undeclared fields for export and annotations streams #25056

darynaishchenko · 2023-04-11T15:03:05Z

resolved Source Mixpanel: Add undeclared columns to spec #24490 (set HttpAvailabilityStrategy)
resolved Source source-mixpanel: implement AvailabilityStrategy #22262 (added fields to schema)
Also was updated backoff: set exponential backoff as docs recommends it. 60s in backoff calculation as delay were set on testing result. 1 request per minute were removed because API allows to send more request per minute, so we can decrease time of work of connector. If we receive 429 error backoff will handle it.

…and export streams

darynaishchenko · 2023-04-11T15:03:55Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4669033583

darynaishchenko · 2023-04-13T18:40:41Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4692715898

darynaishchenko · 2023-04-14T09:36:30Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4698461685

darynaishchenko · 2023-04-14T14:07:33Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4700668393

darynaishchenko · 2023-04-19T07:07:45Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4740524252

darynaishchenko · 2023-04-19T11:21:47Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4742716837

darynaishchenko · 2023-04-19T19:36:31Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4747225657

darynaishchenko · 2023-04-21T14:31:52Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4765953835

darynaishchenko · 2023-04-23T11:18:17Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4778018464

darynaishchenko · 2023-04-24T08:11:29Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4783992824

darynaishchenko · 2023-04-24T19:42:14Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4790412942

darynaishchenko · 2023-04-25T10:05:39Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4796231315
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4796231315
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/utils.py                         8      0   100%
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              57      0   100%
source_mixpanel/streams/cohorts.py              15      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/streams/base.py                 95      4    96%
source_mixpanel/streams/export.py               70      3    96%
source_mixpanel/streams/engage.py               88      6    93%
source_mixpanel/source.py                       79      8    90%
source_mixpanel/streams/annotations.py          16      3    81%
source_mixpanel/streams/cohort_members.py       21      7    67%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          522     42    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 41 passed, 1 skipped in 7863.43s (2:11:03) ==================

airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/base.py

airbyte-integrations/connectors/source-mixpanel/source_mixpanel/schemas/annotations.json

lazebnyi

Nice!

bnchrch

Looks good.

Before you merge would you

Please make sure you update the version in both the source_definition.yaml and metadata.yaml file
Run processResources

darynaishchenko · 2023-04-27T08:44:51Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4817814234

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-mixpanel	0.1.32	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

darynaishchenko · 2023-04-27T16:43:20Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4822299038

Connector	Version	Did it publish?	Were definitions generated?

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

darynaishchenko · 2023-04-28T07:17:07Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4828084680

Connector	Version	Did it publish?	Were definitions generated?

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

darynaishchenko · 2023-04-28T07:32:48Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4828199689

Connector	Version	Did it publish?	Were definitions generated?

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

darynaishchenko · 2023-05-02T07:34:36Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4858748155

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-mixpanel	0.1.32	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

darynaishchenko · 2023-05-02T13:07:09Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4861561537

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-mixpanel	0.1.32	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

darynaishchenko · 2023-05-02T17:05:54Z

/publish connector=connectors/source-mixpanel

darynaishchenko · 2023-05-02T17:23:31Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4863999124

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-mixpanel	0.1.32	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

… for export and annotations streams (airbytehq#25056) * added HttpAvailabilityStrategy and undeclared fields for annotations and export streams * added extra fields to export stream, updated expected records * added exponential backoff * changed testing range days to 10 * updated expected records, added typeTransformer to exports stream * added changelog * removed HttpAvailabilityStrategy property * added null in type for annotations schema * removed unused imports in base.py * bump version in metadata.yaml * updated expected records * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

added HttpAvailabilityStrategy and undeclared fields for annotations …

fc4d639

…and export streams

darynaishchenko self-assigned this Apr 11, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel labels Apr 11, 2023

added extra fields to export stream, updated expected records

feadb38

darynaishchenko force-pushed the daryna/source-mixpanel/24944-improvement branch from 53495cb to 0dbe389 Compare April 14, 2023 14:07

added exponential backoff

6918def

darynaishchenko force-pushed the daryna/source-mixpanel/24944-improvement branch from 70116d0 to 6918def Compare April 21, 2023 14:31

changed testing range days to 10

a554c4f

darynaishchenko force-pushed the daryna/source-mixpanel/24944-improvement branch from 9af7127 to a554c4f Compare April 24, 2023 08:11

updated expected records, added typeTransformer to exports stream

96e5b3a

added changelog

39ea676

darynaishchenko changed the title ~~Source Mixpanel: improvement~~ Source Mixpanel: added HttpAvailabilityStrategy and undeclared fields for export and annotations streams Apr 25, 2023

darynaishchenko requested review from artem1205 and lazebnyi April 25, 2023 13:36

artem1205 reviewed Apr 25, 2023

View reviewed changes

airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/base.py Outdated Show resolved Hide resolved

removed HttpAvailabilityStrategy property

3a1b5a6

artem1205 reviewed Apr 25, 2023

View reviewed changes

airbyte-integrations/connectors/source-mixpanel/source_mixpanel/schemas/annotations.json Outdated Show resolved Hide resolved

added null in type for annotations schema

f1049f0

artem1205 approved these changes Apr 25, 2023

View reviewed changes

lazebnyi approved these changes Apr 25, 2023

View reviewed changes

darynaishchenko requested a review from bnchrch April 26, 2023 07:26

removed unused imports in base.py

0490c49

bnchrch approved these changes Apr 27, 2023

View reviewed changes

Merge branch 'master' into daryna/source-mixpanel/24944-improvement

1f8d9d4

Merge branch 'master' into daryna/source-mixpanel/24944-improvement

b1eaa09

darynaishchenko and others added 2 commits April 28, 2023 11:25

bump version in metadata.yaml

96dbb0a

Merge branch 'master' into daryna/source-mixpanel/24944-improvement

fc37da3

updated expected records

ec51c9d

octavia-squidington-iii and others added 2 commits May 2, 2023 19:45

auto-bump connector version

c53a212

Merge branch 'master' into daryna/source-mixpanel/24944-improvement

6c4daa9

darynaishchenko merged commit 7c36b5f into master May 3, 2023
20 checks passed

darynaishchenko deleted the daryna/source-mixpanel/24944-improvement branch May 3, 2023 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Mixpanel: added HttpAvailabilityStrategy and undeclared fields for export and annotations streams #25056

Source Mixpanel: added HttpAvailabilityStrategy and undeclared fields for export and annotations streams #25056

darynaishchenko commented Apr 11, 2023 •

edited

Loading

darynaishchenko commented Apr 11, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 13, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 14, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 14, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 19, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 19, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 19, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 21, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 23, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 24, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 24, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 25, 2023 •

edited by github-actions bot

Loading

lazebnyi left a comment

bnchrch left a comment

darynaishchenko commented Apr 27, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 27, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 28, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 28, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 2, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 2, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 2, 2023

darynaishchenko commented May 2, 2023 •

edited by github-actions bot

Loading

Source Mixpanel: added HttpAvailabilityStrategy and undeclared fields for export and annotations streams #25056

Source Mixpanel: added HttpAvailabilityStrategy and undeclared fields for export and annotations streams #25056

Conversation

darynaishchenko commented Apr 11, 2023 • edited Loading

darynaishchenko commented Apr 11, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 13, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 14, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 14, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 19, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 19, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 19, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 21, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 23, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 24, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 24, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 25, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi left a comment

Choose a reason for hiding this comment

bnchrch left a comment

Choose a reason for hiding this comment

darynaishchenko commented Apr 27, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 27, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 28, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 28, 2023 • edited by github-actions bot Loading

darynaishchenko commented May 2, 2023 • edited by github-actions bot Loading

darynaishchenko commented May 2, 2023 • edited by github-actions bot Loading

darynaishchenko commented May 2, 2023

darynaishchenko commented May 2, 2023 • edited by github-actions bot Loading

darynaishchenko commented Apr 11, 2023 •

edited

Loading

darynaishchenko commented Apr 11, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 13, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 14, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 14, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 19, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 19, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 19, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 21, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 23, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 24, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 24, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 25, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 27, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 27, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 28, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Apr 28, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 2, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 2, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented May 2, 2023 •

edited by github-actions bot

Loading