-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Google Analytics Data API: implement advanced reports #25179
Source Google Analytics Data API: implement advanced reports #25179
Conversation
/test connector=connectors/source-google-analytics-data-api
|
/test connector=connectors/source-google-analytics-data-api
Build FailedTest summary info:
|
/test connector=connectors/source-google-analytics-data-api
|
/test connector=connectors/source-google-analytics-data-api
Build PassedTest summary info:
|
next_page_token: Mapping[str, Any] = None, | ||
) -> Optional[Mapping]: | ||
# https://developers.google.com/analytics/devguides/reporting/data/v1/rest/v1beta/CohortSpec#Cohort.FIELDS.date_range | ||
# In a cohort request, this dateRange is required and the dateRanges in the RunReportRequest or RunPivotReportRequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you delete dateRange from payload if you said that is required for cohort request. And this mixin is parent only for cohort report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are different date ranges. The one in the root of the payload should be unspecified because there is another one inside the "cohortSpec" object (see schema for details).
This mixin is one of the base classes for the dynamically created report if there's a "cohortSpec" object in the report definition. It can be either a regular report or a pivot report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davydov-d! Just a few questions for you.
...ations/connectors/source-google-analytics-data-api/integration_tests/configured_catalog.json
Show resolved
Hide resolved
...tions/connectors/source-google-analytics-data-api/source_google_analytics_data_api/source.py
Outdated
Show resolved
Hide resolved
...ogle-analytics-data-api/source_google_analytics_data_api/defaults/custom_reports_schema.json
Show resolved
Hide resolved
...ogle-analytics-data-api/source_google_analytics_data_api/defaults/custom_reports_schema.json
Outdated
Show resolved
Hide resolved
...tions/connectors/source-google-analytics-data-api/source_google_analytics_data_api/source.py
Show resolved
Hide resolved
Hi @clnoll, @davydov-d is currently on PTO, so I'll dive into this PR and answer your questions regarding it a bit later. |
/test connector=connectors/source-google-analytics-data-api
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...ations/connectors/source-google-analytics-data-api/integration_tests/configured_catalog.json
Show resolved
Hide resolved
...tions/connectors/source-google-analytics-data-api/source_google_analytics_data_api/source.py
Show resolved
Hide resolved
…plement-advanced-reports
/publish connector=connectors/source-google-analytics-data-api
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…hq#25179) * airbytehq#11689 source Google Analytics Data API: implement advanced reports * airbytehq#11689 source GA data API: upd changelog * airbytehq#11689 source GA data API: fix CAT * airbytehq#11689 source GA data API: fix CAT * Have empty dict as default option * Remove dateRange and dimensions from required params * Generate source defintions manually --------- Co-authored-by: Arsen Losenko <20901439+arsenlosenko@users.noreply.github.com>
What
#11689
How
Implement support for Cohort reports and Pivot reports according to https://developers.google.com/analytics/devguides/reporting/data/v1