Source Zoom: Replace JWT Auth methods with server-to-server Oauth #25308

KqLLL · 2023-04-19T07:13:31Z

What

Describe what the change is solving
Update the Auth method

According to the document, the Zoom JWT auth methods will be deprecated on June 1, 2023. The Zoom source connector only supports JWT and will stop working at that time.

https://marketplace.zoom.us/docs/guides/build/jwt-app/jwt-faq/

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

airbyte-integrations/connectors/source-zoom/source_zoom/components.py

sajarin

Thanks for this PR @KqLLL we really appreciate it. We're unable to test this PR without credentials, so we're waiting for those credentials to be generated.

In the meantime, can you bump the versions in the Dockerfile and metadata.yaml for the Zoom connector? Please keep in mind we follow semantic versioning and this would be considered a major change.

KqLLL · 2023-05-31T07:11:56Z

Thanks for this PR @KqLLL we really appreciate it. We're unable to test this PR without credentials, so we're waiting for those credentials to be generated.

In the meantime, can you bump the versions in the Dockerfile and metadata.yaml for the Zoom connector? Please keep in mind we follow semantic versioning and this would be considered a major change.

I have updated these versions in Dockerfile and metadata.yaml.
Would you mind confirming if I'm doing this correctly?

Just a gentle reminder, if you take some time to study the Zoom API, you might notice that the data provided by the Zoom connector appears to be inaccurate.

RobinHerzog · 2023-07-08T17:45:20Z

Can please someone merge ? JWT does not exist

marcosmarxm · 2023-07-14T10:02:03Z

Hello, we're going to prioritize the review of this contribution next week.

marcosmarxm

Hello 👋 I'm working to get Airbyte's test account to use the new Oauth method. I'm going to return the review after we get them.

marcosmarxm · 2023-07-24T16:48:38Z

@KqLLL still waiting to have the server-to-server Oauth enabled in our integration account. Hope this week we can have a return.

marcosmarxm · 2023-07-26T13:12:01Z

The internal ticket created to our infra team was moved to next sprint. Hope to get this unblock next week. @KqLLL are you available to make a call and maybe show me the connector working in your side?

KqLLL · 2023-07-27T01:26:50Z

The internal ticket created to our infra team was moved to next sprint. Hope to get this unblock next week. @KqLLL are you available to make a call and maybe show me the connector working in your side?

Ok, I can show a snapshot of my connector working.

Set in the source dashboard.

Job history.

marcosmarxm

Can you update the documentation with the note and the Changelog with the new version?

docs/integrations/sources/zoom.md

marcosmarxm

Some comments and we're good to merge the contribution. I'm still working to get credentials from our side but probably we can merge before that.

airbyte-integrations/connectors/source-zoom/Dockerfile

airbyte-integrations/connectors/source-zoom/source_zoom/spec.yaml

marcosmarxm

Thanks @KqLLL

marcosmarxm · 2023-08-01T17:17:13Z

/approve-and-merge reason="Today Airbyte doesnt have a separated Zoom account for only tests purpose. User showed their code implementation is working and also its using the low-code. For future I created a Github issue to have a Zoom credentials working"

octavia-approvington · 2023-08-01T17:17:52Z

Check that box

…5308) * Replace JWT Auth methods with server-to-server Oauth * Bump versions in the Dockerfile and metadata.yaml

DiegoPiloni · 2023-09-07T12:43:44Z

Hi @marcosmarxm @KqLLL, thanks a lot for this work ! Do you have any idea why version 1.0.0 is not in dockerhub ?

jcolinger3 · 2023-10-16T23:42:47Z

Hi @marcosmarxm @KqLLL, thanks a lot for this work ! Do you have any idea why version 1.0.0 is not in dockerhub ?

I'm wondering the same. @DiegoPiloni did you see any change?

DiegoPiloni · 2023-10-17T12:50:39Z

@jcolinger3 What I understand is that #30361 still needs to be approved and merged

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/zoom labels Apr 19, 2023

marcosmarxm changed the title ~~Replace JWT Auth methods with server-to-server Oauth~~ Source Zoom: Replace JWT Auth methods with server-to-server Oauth Apr 20, 2023

marcosmarxm requested changes Apr 21, 2023

View reviewed changes

airbyte-integrations/connectors/source-zoom/source_zoom/components.py Outdated Show resolved Hide resolved

KqLLL requested a review from marcosmarxm April 25, 2023 01:08

marcosmarxm added community-legacy and removed community labels May 15, 2023

marcosmarxm added community and removed community-legacy labels May 30, 2023

sajarin suggested changes May 30, 2023

View reviewed changes

KqLLL requested a review from sajarin June 1, 2023 06:32

jrolom removed the bounty label Jun 9, 2023

marcosmarxm added the team/tse Technical Support Engineers label Jun 27, 2023

marcosmarxm reviewed Jul 19, 2023

View reviewed changes

KqLLL requested a review from marcosmarxm July 27, 2023 02:39

marcosmarxm requested changes Jul 27, 2023

View reviewed changes

docs/integrations/sources/zoom.md Show resolved Hide resolved

marcosmarxm requested changes Jul 27, 2023

View reviewed changes

airbyte-integrations/connectors/source-zoom/Dockerfile Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-zoom/source_zoom/spec.yaml Show resolved Hide resolved

KqLLL added 2 commits July 28, 2023 10:10

Replace JWT Auth methods with server-to-server Oauth

afd1d58

Bump versions in the Dockerfile and metadata.yaml

1dca427

KqLLL requested a review from marcosmarxm July 28, 2023 03:13

marcosmarxm approved these changes Jul 31, 2023

View reviewed changes

octavia-approvington approved these changes Aug 1, 2023

View reviewed changes

octavia-approvington merged commit 4544eb5 into airbytehq:master Aug 1, 2023
7 checks passed

bnchrch pushed a commit that referenced this pull request Aug 3, 2023

Source Zoom: Replace JWT Auth methods with server-to-server Oauth (#2…

07913cb

…5308) * Replace JWT Auth methods with server-to-server Oauth * Bump versions in the Dockerfile and metadata.yaml

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Zoom: Replace JWT Auth methods with server-to-server Oauth #25308

Source Zoom: Replace JWT Auth methods with server-to-server Oauth #25308

KqLLL commented Apr 19, 2023

sajarin left a comment

KqLLL commented May 31, 2023

RobinHerzog commented Jul 8, 2023

marcosmarxm commented Jul 14, 2023

marcosmarxm left a comment

marcosmarxm commented Jul 24, 2023

marcosmarxm commented Jul 26, 2023

KqLLL commented Jul 27, 2023

marcosmarxm left a comment

marcosmarxm left a comment

marcosmarxm left a comment

marcosmarxm commented Aug 1, 2023

octavia-approvington commented Aug 1, 2023

DiegoPiloni commented Sep 7, 2023 •

edited

Loading

jcolinger3 commented Oct 16, 2023

DiegoPiloni commented Oct 17, 2023

Source Zoom: Replace JWT Auth methods with server-to-server Oauth #25308

Source Zoom: Replace JWT Auth methods with server-to-server Oauth #25308

Conversation

KqLLL commented Apr 19, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

sajarin left a comment

Choose a reason for hiding this comment

KqLLL commented May 31, 2023

RobinHerzog commented Jul 8, 2023

marcosmarxm commented Jul 14, 2023

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Jul 24, 2023

marcosmarxm commented Jul 26, 2023

KqLLL commented Jul 27, 2023

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Aug 1, 2023

octavia-approvington commented Aug 1, 2023

DiegoPiloni commented Sep 7, 2023 • edited Loading

jcolinger3 commented Oct 16, 2023

DiegoPiloni commented Oct 17, 2023

DiegoPiloni commented Sep 7, 2023 •

edited

Loading