Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Merge [Low code CDK] #25342

Merged
merged 16 commits into from
May 1, 2023
Merged

Conversation

btkcodedev
Copy link
Collaborator

What

Developing a new connector for the source: Merge

Resolves:
Merge
Part of hackathon week

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance Full Test Results

image

🚨 User Impact 🚨

  • No breaking changes, Just addition of new source
New Connector: Source Merge

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/merge labels Apr 19, 2023
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Apr 19, 2023

PS for the reviewers:
Source Merge is actually pulling data from other linked platforms. It is currently in the beta stages.
Thus most of the endpoints cannot be seeded with the sandbox account. (See screenshot of POST result)

image

Thus the implemented endpoints will give basic information about the merge and its integrated account.
All response-giving endpoints are added.
Please ping via Slack for sharing credentials for testing :)

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are others endpoints. Are you planning to add them too? Left some comments of missing features.

@btkcodedev
Copy link
Collaborator Author

Seeding the endpoints through POST required paid plan, thus adding other streams as empty.

image

@btkcodedev
Copy link
Collaborator Author

Here are the credentials:
{
"account_token": "kVpI78bNtlks9zhDXtaMtyYcpZquh07R2zdpRyHvurnc-JebX5fDcQ",
"api_token": "ZqZvk2yty0ooFNKID8TBsEB13cFjtBFuXBbB0wwq6gV0Tr_Gihxy5g",
"start_date": "2022-03-01T00:00:00.000Z"
}

No worries, Completely made up of temp email creds.

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Apr 20, 2023

The pagination feature added and other stream schemas are updated.
I couldn't seed the endpoints as it requires paid plan, Tests are passing.
Results below:

image

retriever:
$ref: "#/definitions/retriever"

account_details_stream:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you're not adding the /accounts endpoint?

Copy link
Collaborator Author

@btkcodedev btkcodedev Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /accounts is for Accounting Base, the issue was based only for ATS URL
See https://docs.merge.dev/ats/overview/

All the endpoints inside Merge ATS is added :)

@btkcodedev
Copy link
Collaborator Author

@marcosmarxm Bump here :)

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 25, 2023

/test connector=connectors/source-merge

🕑 connectors/source-merge https://github.com/airbytehq/airbyte/actions/runs/4802449368
✅ connectors/source-merge https://github.com/airbytehq/airbyte/actions/runs/4802449368
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
======================== 35 passed, 3 skipped in 42.73s ========================

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 25, 2023

/publish connector=connectors/source-merge

🕑 Publishing the following connectors:
connectors/source-merge
https://github.com/airbytehq/airbyte/actions/runs/4802505622


Connector Version Did it publish? Were definitions generated?
connectors/source-merge 0.1.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@btkcodedev
Copy link
Collaborator Author

@marcosmarxm Please add hackathon-developer-week label

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @btkcodedev I'm having problems publishing the connector. Request help from our connector ops team. All your tasks are done!

@btkcodedev
Copy link
Collaborator Author

Thank you for your continued support & efforts @marcosmarxm

@marcosmarxm
Copy link
Member

marcosmarxm commented May 1, 2023

/publish connector=connectors/source-merge

🕑 Publishing the following connectors:
connectors/source-merge
https://github.com/airbytehq/airbyte/actions/runs/4853198559


Connector Version Did it publish? Were definitions generated?
connectors/source-merge 0.1.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @btkcodedev

@marcosmarxm marcosmarxm merged commit 0f476cf into airbytehq:master May 1, 2023
marcosmarxm added a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Initial commit

* add pagination

* add streams activites, applications, attachments, candidates, departments

* add schemas and stream manifest for eeocs, interviews, offers, offices, jobs, job-interview-stages

* Update spec.yaml

* fix test

* add uuid for merge connector

* update job interview stages

* remove seed files unused

* auto-bump connector version

---------

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants