Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesforce: update API version to 53 #25352

Merged

Conversation

roman-yermilov-gl
Copy link
Collaborator

What

Update API version to 53. #10207

@roman-yermilov-gl roman-yermilov-gl self-assigned this Apr 20, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce labels Apr 20, 2023
@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented Apr 20, 2023

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4754089649
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4754089649
🐛 https://gradle.com/s/mfk6qz3lztioy

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/api_test.py::test_bulk_stream_fallback_to_rest - requests_m...
	 FAILED unit_tests/api_test.py::test_check_connection_rate_limit[200-login_json_resp1-403-discovery_resp_json1-An error occurred: [{"errorCode": "FORBIDDEN", "message": "You do not have enough permissions"}]]
	 FAILED unit_tests/api_test.py::test_too_many_properties - requests_mock.excep...
	 FAILED unit_tests/api_test.py::test_stream_with_no_records_in_response - requ...
	 �[31m============ �[31m�[1m4 failed�[0m, �[32m71 passed�[0m, �[33m242 warnings�[0m�[31m in 117.35s (0:01:57)�[0m�[31m ============�[0m

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented Apr 20, 2023

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4756226813
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4756226813
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_salesforce/utils.py                       8      0   100%
source_salesforce/__init__.py                    2      0   100%
source_salesforce/source.py                    101      6    94%
source_salesforce/streams.py                   400     34    92%
source_salesforce/api.py                       155     14    91%
source_salesforce/exceptions.py                  8      1    88%
source_salesforce/rate_limiting.py              22      3    86%
source_salesforce/availability_strategy.py      17      8    53%
----------------------------------------------------------------
TOTAL                                          713     66    91%
Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_salesforce/__init__.py                    2      0   100%
source_salesforce/exceptions.py                  8      1    88%
source_salesforce/api.py                       155     21    86%
source_salesforce/availability_strategy.py      17      3    82%
source_salesforce/streams.py                   400     88    78%
source_salesforce/rate_limiting.py              22      6    73%
source_salesforce/source.py                    101     33    67%
source_salesforce/utils.py                       8      7    12%
----------------------------------------------------------------
TOTAL                                          713    159    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 2 skipped in 674.69s (0:11:14) ===================

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented Apr 25, 2023

/publish connector=connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented Apr 25, 2023

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/4796570282


Connector Version Did it publish? Were definitions generated?
connectors/source-salesforce 2.0.11

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented Apr 25, 2023

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/4798179910


Connector Version Did it publish? Were definitions generated?
connectors/source-salesforce 2.0.11

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@roman-yermilov-gl roman-yermilov-gl enabled auto-merge (squash) April 25, 2023 14:47
@roman-yermilov-gl roman-yermilov-gl merged commit 6f3cdcf into master Apr 25, 2023
23 of 25 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-salesforce-update_api-version-to-53 branch April 25, 2023 14:55
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Source Salesforce: update API version to 53

* Source Salesforce: update changelog

* Source Salesforce: update version in tests

* Source Salesforce: bump version

* Source Salesforce: update expected records

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants