Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Tiktok Marketing: add new fields to ad reports streams #25423

Merged
merged 17 commits into from Jul 24, 2023

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Apr 24, 2023

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Apr 24, 2023

/publish connector=connectors/source-tiktok-marketing run-tests=false pre-release=true

🕑 Publishing the following connectors:
connectors/source-tiktok-marketing
https://github.com/airbytehq/airbyte/actions/runs/4787398628


Connector Version Did it publish? Were definitions generated?
connectors/source-tiktok-marketing 3.0.1-dev.445a1ccb

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Apr 24, 2023

/publish connector=connectors/source-tiktok-marketing run-tests=false pre-release=true

🕑 Publishing the following connectors:
connectors/source-tiktok-marketing
https://github.com/airbytehq/airbyte/actions/runs/4787625206


Connector Version Did it publish? Were definitions generated?
connectors/source-tiktok-marketing 3.0.1-dev.d972231c

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm
Copy link
Member Author

marcosmarxm commented May 16, 2023

/publish connector=connectors/source-tiktok-marketing run-tests=false pre-release=true

🕑 Publishing the following connectors:
connectors/source-tiktok-marketing
https://github.com/airbytehq/airbyte/actions/runs/4995377766


Connector Version Did it publish? Were definitions generated?
connectors/source-tiktok-marketing 3.0.1-dev.e990e87a

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 73782cbd25) - ❌

⏲️ Total pipeline duration: 103 seconds

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 26, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 1737a4a978) - ❌

⏲️ Total pipeline duration: 857 seconds

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 92e4dadb9a) - ❌

⏲️ Total pipeline duration: 15mn12s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit ffe252bab2) - ❌

⏲️ Total pipeline duration: 14mn06s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 394c508590) - ❌

⏲️ Total pipeline duration: 01mn04s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 912e1cd765) - ❌

⏲️ Total pipeline duration: 30mn07s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 83a65d62bf) - ❌

⏲️ Total pipeline duration: 28mn30s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 28031ae610) - ❌

⏲️ Total pipeline duration: 28mn37s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit c87334e3bc) - ❌

⏲️ Total pipeline duration: 32mn51s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-tiktok-marketing test report (commit 2b64754a05) - ✅

⏲️ Total pipeline duration: 31mn36s

Step Result
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-tiktok-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@sajarin sajarin merged commit 6b588d0 into master Jul 24, 2023
22 of 23 checks passed
@sajarin sajarin deleted the marcos/tiktok-add-purchase-fields branch July 24, 2023 19:44
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
…ehq#25423)

* add new fields to ad reports streams

* fix unit test

* fix test and check connection

* fix unit test

* add conversions too

* add additional fields

* fix: format python files with flake

* fix: add cta_conversion, vta_conversion to streams.py

* fix: python format

* fix: updated expected_records for ad_reports stream

---------

Co-authored-by: sajarin <sajarindider@gmail.com>
Co-authored-by: Augustin <augustin@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/tiktok-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants