Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source File: Add datatime format parsing support for csv files #25445

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Apr 24, 2023

What

Source: File - Unable to set dtype to datetime in reader option - User want parse datetime field as datetime.

How

Added an option to specify a date analysis column in the configuration using the read_options parameter.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Apr 24, 2023

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/4790894428
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/4790894428
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        81      7    91%
source_file/client.py       291     38    87%
---------------------------------------------
TOTAL                       387     46    88%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       291     45    85%
source_file/utils.py         13      8    38%
source_file/source.py        81     60    26%
---------------------------------------------
TOTAL                       387    113    71%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 48.79s ========================

@lazebnyi lazebnyi changed the title Source File: Add datatime format parsing support for csv files 🎉Source File: Add datatime format parsing support for csv files Apr 25, 2023
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Apr 25, 2023

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/4795681911


Connector Version Did it publish? Were definitions generated?
connectors/source-file 0.3.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi removed the request for review from artem1205 April 25, 2023 09:06
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Apr 25, 2023

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/4795939710


Connector Version Did it publish? Were definitions generated?
connectors/source-file-secure 0.3.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi merged commit 3bfcdda into master Apr 25, 2023
@lazebnyi lazebnyi deleted the lazebnyi/1853-source-file-add-datetime branch April 25, 2023 09:57
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…ytehq#25445)

* Add datatime format parsing support

* Updated subject in docs

* Bump file secure

* PR number bumped

* Fix typo

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file connectors/source/file-secure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants