🎉 New Source: FullStory [Low code CDK] #25465

amogh-opsverse · 2023-04-25T03:19:06Z

What

Developing new connector for the source: FullStory

Resolves:
airbytehq/DeveloperWeek-Connector-Contest#13

How

Developed using (Configuration Based Source) low-code CDK and connector-builder UI

Tests

Integration & Acceptance

🚨 User Impact 🚨

No breaking changes, Just addition of new source

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector: FullStory

Community member or Airbyter

CLAassistant · 2023-04-25T03:19:13Z

All committers have signed the CLA.

marcosmarxm

Left some comments. Thanks for the contribution @amogh-opsverse

airbyte-integrations/connectors/source-fullstory/source_fullstory/schemas/TODO.md

airbyte-integrations/connectors/source-fullstory/source_fullstory/manifest.yaml

amogh-opsverse · 2023-04-25T20:29:07Z

Left some comments. Thanks for the contribution @amogh-opsverse

Thanks for the feedback, @marcosmarxm. Btw, i'm running into this weird behavior with running the acceptance tests where they're starting to fail with the following error. The tests ran fine yesterday, could you please give me some info about this?

marcosmarxm · 2023-04-25T21:24:54Z

Left some comments. Thanks for the contribution @amogh-opsverse

Thanks for the feedback, @marcosmarxm. Btw, i'm running into this weird behavior with running the acceptance tests where they're starting to fail with the following error. The tests ran fine yesterday, could you please give me some info about this?

Can you push latest version of your changes?

marcosmarxm · 2023-04-25T21:35:15Z

Waiting contributor update the code. The version right now is not possible to reproduce issue

amogh-opsverse · 2023-04-25T22:27:14Z

this has been resolved, it was due to a formatting error; latest test results:

amogh-opsverse · 2023-04-26T06:00:19Z

Left some comments. Thanks for the contribution @amogh-opsverse

@marcosmarxm also, please let me know if i'm missing any files. I'd really appreciate it if you could help me merge this PR before the 27th deadline for the bounty.

marcosmarxm

Remove the incremental @amogh-opsverse and ask my review again.

airbyte-integrations/connectors/source-fullstory/source_fullstory/manifest.yaml

marcosmarxm · 2023-05-01T20:26:08Z

@amogh-opsverse please confirm you have granted access to maintainers to your fork.

marcosmarxm · 2023-05-01T20:55:27Z

/test connector=connectors/source-fullstory

🕑 connectors/source-fullstory https://github.com/airbytehq/airbyte/actions/runs/4854841925
❌ connectors/source-fullstory https://github.com/airbytehq/airbyte/actions/runs/4854841925
🐛 https://gradle.com/s/okvcefpzo5kw6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
=================== 1 failed, 34 passed, 3 skipped in 35.06s ===================

marcosmarxm · 2023-05-01T21:43:22Z

/test connector=connectors/source-fullstory

🕑 connectors/source-fullstory https://github.com/airbytehq/airbyte/actions/runs/4855204149
✅ connectors/source-fullstory https://github.com/airbytehq/airbyte/actions/runs/4855204149
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
======================== 35 passed, 3 skipped in 36.55s ========================

marcosmarxm · 2023-05-01T22:19:25Z

/publish connector=connectors/source-fullstory

🕑 Publishing the following connectors:
connectors/source-fullstory
https://github.com/airbytehq/airbyte/actions/runs/4855465369

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-fullstory	0.1.0	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* initial commit * Update spec.yaml * Delete TODO.md * Update manifest.yaml * updating with requested changes * add fullstory source integration doc * updating docs and logo * Update manifest.yaml * Update manifest.yaml * Update configured_catalog.json to remove incremental sync * Update acceptance-test-config.yml to remove incremental tests * Delete expected_records.jsonl * Update abnormal_state.json * Update acceptance-test-config.yml * update accpt test * remove start date from spec not used * fix tests * add fullstory to source def file * Rename eventdefs.json to eventDefs.json * correct dockerfile version in source def * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

initial commit

56ec9ec

amogh-opsverse changed the title ~~🎉 New Source: Aircall [Low code CDK] #25461~~ 🎉 New Source: FullStory [Low code CDK] #25461 Apr 25, 2023

octavia-squidington-iii added area/connectors Connector related issues bounty community connectors/source/fullstory labels Apr 25, 2023

amogh-opsverse changed the title ~~🎉 New Source: FullStory [Low code CDK] #25461~~ 🎉 New Source: FullStory [Low code CDK] Apr 25, 2023

Update spec.yaml

e5dc3cf

marcosmarxm requested changes Apr 25, 2023

View reviewed changes

amogh-opsverse added 2 commits April 25, 2023 11:50

Delete TODO.md

0649f2f

Update manifest.yaml

2b8f129

updating with requested changes

5979f2e

add fullstory source integration doc

139d643

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 25, 2023

updating docs and logo

a525f8d

amogh-opsverse requested a review from marcosmarxm April 25, 2023 23:38

Merge branch 'master' into fullstory

d1bf72b

marcosmarxm added the hackthon-developer-week label Apr 26, 2023

marcosmarxm requested changes Apr 26, 2023

View reviewed changes

airbyte-integrations/connectors/source-fullstory/source_fullstory/manifest.yaml Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-fullstory/source_fullstory/manifest.yaml Outdated Show resolved Hide resolved

amogh-opsverse added 4 commits April 26, 2023 21:20

Update manifest.yaml

0685bd4

Update manifest.yaml

8312aef

Update configured_catalog.json to remove incremental sync

300c30a

Update acceptance-test-config.yml to remove incremental tests

72cad9f

amogh-opsverse requested a review from marcosmarxm April 27, 2023 04:36

amogh-opsverse added 5 commits April 26, 2023 23:04

Merge branch 'master' into fullstory

0127614

Merge branch 'master' into fullstory

eed6ef6

Delete expected_records.jsonl

fa0ebaf

Update abnormal_state.json

5bf2bce

Update acceptance-test-config.yml

6097174

marcosmarxm added 2 commits May 1, 2023 13:48

update accpt test

77812b5

remove start date from spec not used

8b5c057

marcosmarxm and others added 3 commits May 1, 2023 14:12

fix tests

5bac5e1

add fullstory to source def file

4f8f8e5

Rename eventdefs.json to eventDefs.json

6847b85

amogh-opsverse and others added 2 commits May 1, 2023 15:08

Merge branch 'master' into fullstory

ac6fc45

correct dockerfile version in source def

08fc4eb

auto-bump connector version

23990cc

marcosmarxm approved these changes May 1, 2023

View reviewed changes

amogh-opsverse mentioned this pull request May 1, 2023

FullStory Connector airbytehq/DeveloperWeek-Connector-Contest#13

Open

Merge branch 'master' into fullstory

541554f

marcosmarxm merged commit b6d59e6 into airbytehq:master May 1, 2023
24 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: FullStory [Low code CDK] #25465

🎉 New Source: FullStory [Low code CDK] #25465

amogh-opsverse commented Apr 25, 2023 •

edited

Loading

CLAassistant commented Apr 25, 2023 •

edited

Loading

marcosmarxm left a comment

amogh-opsverse commented Apr 25, 2023 •

edited

Loading

marcosmarxm commented Apr 25, 2023

marcosmarxm commented Apr 25, 2023

amogh-opsverse commented Apr 25, 2023

amogh-opsverse commented Apr 26, 2023 •

edited

Loading

marcosmarxm left a comment

marcosmarxm commented May 1, 2023

marcosmarxm commented May 1, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 1, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 1, 2023 •

edited by github-actions bot

Loading

🎉 New Source: FullStory [Low code CDK] #25465

🎉 New Source: FullStory [Low code CDK] #25465

Conversation

amogh-opsverse commented Apr 25, 2023 • edited Loading

What

How

Recommended reading order

Tests

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

CLAassistant commented Apr 25, 2023 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

amogh-opsverse commented Apr 25, 2023 • edited Loading

marcosmarxm commented Apr 25, 2023

marcosmarxm commented Apr 25, 2023

amogh-opsverse commented Apr 25, 2023

amogh-opsverse commented Apr 26, 2023 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented May 1, 2023

marcosmarxm commented May 1, 2023 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented May 1, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented May 1, 2023 • edited by github-actions bot Loading

amogh-opsverse commented Apr 25, 2023 •

edited

Loading

CLAassistant commented Apr 25, 2023 •

edited

Loading

amogh-opsverse commented Apr 25, 2023 •

edited

Loading

amogh-opsverse commented Apr 26, 2023 •

edited

Loading

marcosmarxm commented May 1, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 1, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 1, 2023 •

edited by github-actions bot

Loading