Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Mixpanel: ConnectionResetError fix #25543

Merged
merged 15 commits into from
May 4, 2023
Merged

Source Mixpanel: ConnectionResetError fix #25543

merged 15 commits into from
May 4, 2023

Conversation

darynaishchenko
Copy link
Collaborator

Added should_retry True to avoid ConnectionResetError and retry if it occurs for stream export.

@darynaishchenko darynaishchenko self-assigned this Apr 26, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel labels Apr 26, 2023
@darynaishchenko darynaishchenko linked an issue Apr 26, 2023 that may be closed by this pull request
Source Mixpanel: connection reset by the peer after 40 hours of sync #24177
Closed
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Apr 26, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4807258755

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Apr 26, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4811687584
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4811687584
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 41 passed, 1 skipped in 7795.79s (2:09:55) ==================

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4872850791
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4872850791
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/utils.py                         8      0   100%
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              57      0   100%
source_mixpanel/streams/cohorts.py              15      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/streams/base.py                 90      3    97%
source_mixpanel/streams/export.py               76      5    93%
source_mixpanel/streams/engage.py               88      6    93%
source_mixpanel/source.py                       79      8    90%
source_mixpanel/streams/annotations.py          16      3    81%
source_mixpanel/streams/cohort_members.py       21      7    67%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          523     43    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 7810.45s (2:10:10) ==================

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 3, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4874806397


Connector Version Did it publish? Were definitions generated?
connectors/source-mixpanel 0.1.33 ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@darynaishchenko darynaishchenko merged commit b973bc8 into master May 4, 2023
20 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-mixpanel/fix-connection-error branch May 4, 2023 06:32
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@darynaishchenko @octavia-squidington-iii @marcosmarxm
Source Mixpanel: ConnectionResetError fix (airbytehq#25543)
3f59d2e 
* added HttpAvailabilityStrategy and undeclared fields for annotations and export streams

* added extra fields to export stream, updated expected records

* added exponential backoff

* changed testing range days to 10

* updated expected records, added typeTransformer to exports stream

* added changelog

* removed HttpAvailabilityStrategy property

* added null in type for annotations schema

* removed unused imports in base.py

* added retry for sream export when ConnectionResetError occurs

* added changelog

* fixed version in changelog

* bump version in metadata.md

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@artem1205 artem1205 Awaiting requested review from artem1205

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Mixpanel: connection reset by the peer after 40 hours of sync
3 participants
@darynaishchenko @lazebnyi @octavia-squidington-iii