-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source File: Fix OOM; read Excel files in chunks #25575
Conversation
for sheetname in work_book.sheetnames: | ||
work_sheet = work_book[sheetname] | ||
data = work_sheet.values | ||
cols = next(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty generator can kill you by StopIteration, is it ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated;
/test connector=connectors/source-file
Build FailedTest summary info:
|
/test connector=connectors/source-file
|
/test connector=connectors/source-file
Build PassedTest summary info:
|
/publish connector=connectors/source-file
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* Source File: Use openpyxl to read excel files in chunks * Source File: bump version * Source File: update docs * Source File Secure: bump version * Source File Secure: add docstring * Source File: use column names from reader options * Source File: refactor; use pandas for non xlsx formats * Source File: reformat * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Resolving https://github.com/airbytehq/oncall/issues/1871
How
read Excel files in chunks
Recommended reading order
y.python
🚨 User Impact 🚨
no breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with
airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.Code reviews completed
Connector version has been incremented
Dockerfile
has updated versionDocumentation updated
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
with an entry for the new version. See changelog examplePR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here