Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source File: Handle network errors #25641

Merged
merged 6 commits into from
May 1, 2023
Merged

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Apr 27, 2023

What

Resolving https://github.com/airbytehq/oncall/issues/1743

How

handle network errors

Recommended reading order

  1. y.python

🚨 User Impact 🚨

no breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing, toggle the github label checklist-action-run on/off to re-run the checklist.

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog, version bump, and new checklist are waiting for you.

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes asked by @bazarnov looks good to me.

# Conflicts:
#	airbyte-integrations/connectors/source-file/source_file/client.py
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/file-secure labels May 1, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented May 1, 2023

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/4851300712
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/4851300712
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        81      7    91%
source_file/client.py       322     56    83%
---------------------------------------------
TOTAL                       418     64    85%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       322     51    84%
source_file/utils.py         13      8    38%
source_file/source.py        81     60    26%
---------------------------------------------
TOTAL                       418    119    72%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 50.61s ========================

@artem1205
Copy link
Collaborator Author

artem1205 commented May 1, 2023

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/4851373942


Connector Version Did it publish? Were definitions generated?
connectors/source-file 0.3.2

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205
Copy link
Collaborator Author

artem1205 commented May 1, 2023

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/4851376012


Connector Version Did it publish? Were definitions generated?
connectors/source-file-secure 0.3.2

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205 artem1205 merged commit 814b4f7 into master May 1, 2023
21 of 23 checks passed
@artem1205 artem1205 deleted the artem1205/source-file-OC-1743 branch May 1, 2023 13:52
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Source File: Handle network errors

* Source File: Add unit test

* Source File: bump version + docs update

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file connectors/source/file-secure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants