-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source File: Handle network errors #25641
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing, toggle the github label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog, version bump, and new checklist are waiting for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With changes asked by @bazarnov looks good to me.
# Conflicts: # airbyte-integrations/connectors/source-file/source_file/client.py
/test connector=connectors/source-file
Build PassedTest summary info:
|
/publish connector=connectors/source-file
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-file-secure
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* Source File: Handle network errors * Source File: Add unit test * Source File: bump version + docs update * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Resolving https://github.com/airbytehq/oncall/issues/1743
How
handle network errors
Recommended reading order
y.python
🚨 User Impact 🚨
no breaking changes