Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 CAT: fix close-com, confluence, gitlab, pipedrive, slack, xero expected records #25780

Merged
merged 1 commit into from
May 3, 2023
Merged

🐛 CAT: fix close-com, confluence, gitlab, pipedrive, slack, xero expected records #25780

merged 1 commit into from
May 3, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented May 3, 2023

What

Based on these CAT tests:

Need to fix expected records to pass CAT.

How

  • edited expected records.jsonl with updated record set

@bazarnov bazarnov self-assigned this May 3, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited by bazarnov
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov
Copy link
Collaborator Author

bazarnov commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-close-com

🕑 connectors/source-close-com https://github.com/airbytehq/airbyte/actions/runs/4871701628
✅ connectors/source-close-com https://github.com/airbytehq/airbyte/actions/runs/4871701628
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 315.84s (0:05:15) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/4871702796
✅ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/4871702796
Python tests coverage:

Name                            Stmts   Miss  Cover
---------------------------------------------------
source_confluence/__init__.py       2      0   100%
source_confluence/source.py        94      3    97%
---------------------------------------------------
TOTAL                              96      3    97%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 38.30s ========================

@bazarnov
Copy link
Collaborator Author

bazarnov commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4871704138
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4871704138
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/auth.py           8      0   100%
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        38      2    95%
source_pipedrive/streams.py       98     15    85%
--------------------------------------------------
TOTAL                            146     17    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 2 skipped in 124.02s (0:02:04) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4871706008
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/4871706008
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_slack/__init__.py       2      0   100%
source_slack/source.py       225     19    92%
----------------------------------------------
TOTAL                        227     19    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 40 passed, 2 skipped in 40.09s ========================

@bazarnov
Copy link
Collaborator Author

bazarnov commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-xero

🕑 connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4871707723
✅ connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4871707723
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_xero/source.py        25      0   100%
source_xero/__init__.py       2      0   100%
source_xero/streams.py      159      8    95%
source_xero/oauth.py         28     15    46%
---------------------------------------------
TOTAL                       214     23    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 989.15s (0:16:29) ===================

@bazarnov bazarnov requested review from arsenlosenko and removed request for lazebnyi May 3, 2023 12:18
@bazarnov
Copy link
Collaborator Author

bazarnov commented May 3, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/4872024941
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/4872024941
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gitlab/__init__.py       2      0   100%
source_gitlab/source.py        61      3    95%
source_gitlab/streams.py      279     15    95%
-----------------------------------------------
TOTAL                         342     18    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 43 passed, 2 skipped in 587.31s (0:09:47) ===================

@bazarnov bazarnov merged commit 1780ee1 into master May 3, 2023
32 of 39 checks passed
@bazarnov bazarnov deleted the baz/fix-multiple-expected-recs branch May 3, 2023 13:06
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@bazarnov @marcosmarxm
🐛 CAT: fix close-com, confluence, gitlab, pipedrive, slack, xero expe…
57506fa 
…cted records (airbytehq#25780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsenlosenko arsenlosenko arsenlosenko approved these changes

@artem1205 artem1205 artem1205 approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues checklist-action-run connectors/source/close-com connectors/source/confluence connectors/source/gitlab connectors/source/pipedrive connectors/source/slack connectors/source/xero team/connectors-python
Projects
GL Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bazarnov @arsenlosenko @artem1205 @octavia-squidington-iii