🐛 Destination S3 Glue: Fix decimal type syntax #25813
Conversation
The definition of the decimal type as `decimal(38,38)` was incorrect as it caused the query engine to interpret that as meaning that all 38 digits had to be to the right of the decimal place, so any whole number values would overflow. Setting it as `decimal(38)` allows for the full 38 digits, but with flexible scale.
|
/publish connector=connectors/destination-s3-glue
if you have connectors that successfully published but failed definition generation, follow step 4 here |
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (1)
| Connector | Version | Changelog | Publish |
|---|---|---|---|
destination-s3-glue |
0.1.7 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
|
/test connector=connectors/destination-s3-glue
Build PassedTest summary info: |
|
/publish connector=connectors/destination-s3-glue
if you have connectors that successfully published but failed definition generation, follow step 4 here |
marcosmarxm
changed the title
|
/publish connector=connectors/destination-s3-glue
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* destination-s3-glue: Fix decimal type syntax The definition of the decimal type as `decimal(38,38)` was incorrect as it caused the query engine to interpret that as meaning that all 38 digits had to be to the right of the decimal place, so any whole number values would overflow. Setting it as `decimal(38)` allows for the full 38 digits, but with flexible scale. * auto-bump connector version --------- Co-authored-by: Tobias Macey <tmacey@mit.edu> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
The definition of the decimal type as
decimal(38,38)was incorrect as it caused the query engine to interpret that as meaning that all 38 digits had to be to the right of the decimal place, so any whole number values would overflow. Setting it asdecimal(38)allows for the full 38 digits, but with flexible scale.What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.0.0.1Dockerfilehas version0.0.1README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog with an entry for the initial version. See changelog exampledocs/integrations/README.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes