Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 source-file GCP token is a secret #25819

Merged
merged 4 commits into from
May 5, 2023
Merged

Conversation

evantahler
Copy link
Contributor

cc @TBernstein4

@evantahler evantahler added the type/bug Something isn't working label May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@pedroslopez
Copy link
Contributor

Remember to bump version and update the changelog :D

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 5, 2023
@evantahler evantahler changed the title source-file GCP token is a secret 🐛 source-file GCP token is a secret May 5, 2023
@evantahler
Copy link
Contributor Author

evantahler commented May 5, 2023

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/4888557369
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/4888557369
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        81      7    91%
source_file/client.py       322     56    83%
---------------------------------------------
TOTAL                       418     64    85%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       322     51    84%
source_file/utils.py         13      8    38%
source_file/source.py        81     60    26%
---------------------------------------------
TOTAL                       418    119    72%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 36 passed, 2 skipped in 76.77s (0:01:16) ===================

@evantahler evantahler marked this pull request as ready for review May 5, 2023 00:17
@evantahler
Copy link
Contributor Author

evantahler commented May 5, 2023

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/4889653934


Connector Version Did it publish? Were definitions generated?
connectors/source-file 0.3.3

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@evantahler evantahler enabled auto-merge (squash) May 5, 2023 03:46
@evantahler evantahler disabled auto-merge May 5, 2023 03:49
@evantahler evantahler merged commit 63d0402 into master May 5, 2023
14 of 15 checks passed
@evantahler evantahler deleted the evantahler-patch-2 branch May 5, 2023 03:49
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* source-file GCP token is a secret

* docs and changelog

* bump metadata

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants