connectors-ci: handle strict encrypt connectors #25864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnchrch
approved these changes
May 8, 2023
| @@ -430,10 +430,16 @@ def build_include(self) -> List[str]: | |||
| Returns: | |||
| List[str]: List of directories or files to be mounted to the container to run a Java connector Gradle task. | |||
| """ | |||
| additional_inclusion = [] | |||
There was a problem hiding this comment.
Nit: Why an array and not a single value?
| @@ -430,10 +430,16 @@ def build_include(self) -> List[str]: | |||
| Returns: | |||
| List[str]: List of directories or files to be mounted to the container to run a Java connector Gradle task. | |||
| """ | |||
| additional_inclusion = [] | |||
| if self.context.connector.technical_name.endswith("-strict-encrypt"): | |||
There was a problem hiding this comment.
Idea: it would be great if we had a more explicit mapping
related_connectors = {
"source-file-secure": ["source-file"],
"source-postgres-strict-encrypt": ["source-postgres"]
# ...
,}There was a problem hiding this comment.
I'd prefer to not hardcode and maintain the list of strict-encrypted connectors in the pipeline.
I created a dedicated function that will hopefully provide a bit more readability: dcb6bcc
alafanechere
deleted the
augustin/connectors-ci/handle-strict-encrypt-connectors
branch
This was referenced May 9, 2023
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #25846
The strict encrypt connectors were not testable with the CLI because we used the OSS registry to get the list of available connectors.
How
metadata.yamlfile