airbytehq · roman-yermilov-gl · Jun 20, 2023 · May 8, 2023 · May 9, 2023 · May 31, 2023
diff --git a/airbyte-integrations/connectors/source-amazon-ads/Dockerfile b/airbyte-integrations/connectors/source-amazon-ads/Dockerfile
@@ -14,5 +14,5 @@ ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
 
 
-LABEL io.airbyte.version=1.1.0
+LABEL io.airbyte.version=2.0.0
 LABEL io.airbyte.name=airbyte/source-amazon-ads
diff --git a/airbyte-integrations/connectors/source-amazon-ads/acceptance-test-config.yml b/airbyte-integrations/connectors/source-amazon-ads/acceptance-test-config.yml
@@ -37,6 +37,8 @@ acceptance_tests:
   discovery:
     tests:
       - config_path: secrets/config.json
+        backward_compatibility_tests_config:
+          disable_for_version: 1.1.0
   full_refresh:
     tests:
       - config_path: secrets/config.json

diff --git a/airbyte-integrations/connectors/source-amazon-ads/integration_tests/__init__.py b/airbyte-integrations/connectors/source-amazon-ads/integration_tests/__init__.py
@@ -0,0 +1,3 @@
+#
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
+#
diff --git a/airbyte-integrations/connectors/source-amazon-ads/integration_tests/expected_records.jsonl b/airbyte-integrations/connectors/source-amazon-ads/integration_tests/expected_records.jsonl
@@ -50,7 +50,7 @@
 {"stream":"sponsored_display_targetings","data":{"adGroupId":239470166910761,"bid":0.4,"expression":[{"type":"similarProduct"}],"expressionType":"auto","resolvedExpression":[{"type":"similarProduct"}],"state":"enabled","targetId":124150067548052},"emitted_at":1659020220625}
 {"stream": "sponsored_product_campaigns", "data": {"campaignId": 39413387973397, "name": "Test campaging for profileId 1861552880916640", "campaignType": "sponsoredProducts", "targetingType": "manual", "premiumBidAdjustment": true, "dailyBudget": 10.0, "ruleBasedBudget": {"isProcessing": false}, "startDate": "20220705", "endDate": "20220712", "state": "paused", "bidding": {"strategy": "legacyForSales", "adjustments": [{"predicate": "placementTop", "percentage": 50}]}, "tags": {"PONumber": "examplePONumber", "accountManager": "exampleAccountManager"}}, "emitted_at": 1677630109443}
 {"stream": "sponsored_product_campaigns", "data": {"campaignId": 135264288913079, "name": "Campaign - 7/5/2022 18:14:02", "campaignType": "sponsoredProducts", "targetingType": "auto", "premiumBidAdjustment": false, "dailyBudget": 10.0, "startDate": "20220705", "state": "enabled", "bidding": {"strategy": "legacyForSales", "adjustments": []}}, "emitted_at": 1677630109611}
-{"stream": "sponsored_product_campaigns", "data": {"campaignId": 191249325250025, "name": "Campaign - 7/8/2022 13:57:48", "campaignType": "sponsoredProducts", "targetingType": "auto", "premiumBidAdjustment": true, "dailyBudget": 50.0, "startDate": "20220708", "state": "enabled", "bidding": {"strategy": "legacyForSales", "adjustments": [{"predicate": "placementProductPage", "percentage": 100}, {"predicate": "placementTop", "percentage": 100}]}}, "emitted_at": 1677630109612}
+{"stream": "sponsored_product_campaigns", "data": {"campaignId": 191249325250025, "name": "Campaign - 7/8/2022 13:57:48", "campaignType": "sponsoredProducts", "targetingType": "auto", "premiumBidAdjustment": true, "dailyBudget": 50.0, "ruleBasedBudget": {"isProcessing": false}, "startDate": "20220708", "state": "enabled", "bidding": {"strategy": "legacyForSales", "adjustments": [{"predicate": "placementProductPage", "percentage": 100}, {"predicate": "placementTop", "percentage": 100}]}}, "emitted_at": 1677630109612}
 {"stream": "sponsored_product_campaigns", "data": {"campaignId": 146003174711486, "name": "Test campaging for profileId 3039403378822505", "campaignType": "sponsoredProducts", "targetingType": "manual", "premiumBidAdjustment": true, "dailyBudget": 2.0, "startDate": "20220705", "endDate": "20231111", "state": "enabled", "bidding": {"strategy": "legacyForSales", "adjustments": [{"predicate": "placementTop", "percentage": 50}]}, "tags": {"PONumber": "examplePONumber", "accountManager": "exampleAccountManager"}}, "emitted_at": 1677630109776}
 {"stream":"sponsored_product_ad_groups","data":{"adGroupId":226404883721634,"name":"My AdGroup for Campaign 39413387973397","campaignId":39413387973397,"defaultBid":10,"state":"enabled"},"emitted_at":1659020222108}
 {"stream":"sponsored_product_ad_groups","data":{"adGroupId":183961953969922,"name":"Ad group - 7/5/2022 18:14:02","campaignId":135264288913079,"defaultBid":0.75,"state":"enabled"},"emitted_at":1659020222276}

diff --git a/airbyte-integrations/connectors/source-amazon-ads/metadata.yaml b/airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
@@ -8,7 +8,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246
-  dockerImageTag: 1.1.0
+  dockerImageTag: 2.0.0
   dockerRepository: airbyte/source-amazon-ads
   githubIssueLabel: source-amazon-ads
   icon: amazonads.svg

diff --git a/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/__init__.py b/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/__init__.py
@@ -1,25 +1,5 @@
 #
-# MIT License
-#
-# Copyright (c) 2020 Airbyte
-#
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-#
-# The above copyright notice and this permission notice shall be included in all
-# copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-# SOFTWARE.
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 #
 
 

diff --git a/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/__init__.py b/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/__init__.py
@@ -1,25 +1,5 @@
 #
-# MIT License
-#
-# Copyright (c) 2020 Airbyte
-#
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-#
-# The above copyright notice and this permission notice shall be included in all
-# copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-# SOFTWARE.
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 #
 from .attribution_report import AttributionReportModel
 from .common import CatalogModel, Keywords, MetricsReport, NegativeKeywords

diff --git a/...e-integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/sponsored_brands.py b/...e-integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/sponsored_brands.py
@@ -19,7 +19,7 @@ class BrandsCampaign(CatalogModel):
     state: str
     servingStatus: str
     brandEntityId: str
-    portfolioId: Decimal
+    portfolioId: int
     bidOptimization: bool = None
     bidMultiplier: Decimal = None
     adFormat: str

diff --git a/...-integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/sponsored_display.py b/...-integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/sponsored_display.py
@@ -17,7 +17,7 @@ class DisplayCampaign(CatalogModel):
     endDate: str = None
     costType: str
     state: str
-    portfolioId: str = None
+    portfolioId: int = None
     tactic: str
     deliveryProfile: str
 

diff --git a/...integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/sponsored_products.py b/...integrations/connectors/source-amazon-ads/source_amazon_ads/schemas/sponsored_products.py
@@ -19,7 +19,7 @@ class Bidding(CatalogModel):
 
 
 class ProductCampaign(CatalogModel):
-    portfolioId: Decimal
+    portfolioId: int
     campaignId: Decimal
     name: str
     tags: Dict[str, str]

diff --git a/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/__init__.py b/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/__init__.py
@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 #
 from .attribution_report import (
     AttributionReportPerformanceAdgroup,

diff --git a/...rations/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/__init__.py b/...rations/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/__init__.py
@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
 #
 from .brands_report import SponsoredBrandsReportStream
 from .brands_video_report import SponsoredBrandsVideoReportStream

diff --git a/airbyte-integrations/connectors/source-amazon-ads/unit_tests/__init__.py b/airbyte-integrations/connectors/source-amazon-ads/unit_tests/__init__.py
@@ -0,0 +1,3 @@
+#
+# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
+#
diff --git a/docs/integrations/sources/amazon-ads.md b/docs/integrations/sources/amazon-ads.md
@@ -94,6 +94,7 @@ Information about expected report generation waiting time you may find [here](ht
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                         |
 |:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------|
+| 2.0.0   | 2023-05-31 | [25874](https://github.com/airbytehq/airbyte/pull/25874) | Type `portfolioId` as integer                                                                                   |
 | 1.1.0   | 2023-04-22 | [25412](https://github.com/airbytehq/airbyte/pull/25412) | Add missing reporting metrics                                                                                   |
 | 1.0.6   | 2023-05-09 | [25913](https://github.com/airbytehq/airbyte/pull/25913) | Small schema fixes                                                                                              |
 | 1.0.5   | 2023-05-08 | [25885](https://github.com/airbytehq/airbyte/pull/25885) | Improve error handling for attribution_report(s) streams                                                        |