🐛 Source Mixpanel, Source Pinterest, Source Freshdesk: fix builds #25915

davydov-d · 2023-05-09T12:51:12Z

What

Fix builds for:

Source Mixpanel. Expected Records Mismatch: data went missing in one of the streams - Export.
Source Pipedrive. Expected Records Mismatch: stream emits records that contain extra fields (neither exposed in schema nor documented in the api reference).
Source Freshdesk. Expected Records Mismatch: stream TicketFields - new item added to the choices field in one of the records: "Chat - Internal Task": 14
Source Pinterest. Expected Records Mismatch: the schema used to be missing a field. Stream BoardPins now has one more field: creative_type

How

Mixpanel: refill the stream and update expected records
Pipedrive: Do not emit undocumented fields as part of a record
Freshdesk: update expected records
Pinterest: update expected records + expose new field in the stream schema, bump version

…terest

github-actions · 2023-05-09T12:51:59Z

davydov-d · 2023-05-09T12:54:09Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4925927190
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4925927190
Python tests coverage:

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_freshdesk/source.py                     22      0   100%
source_freshdesk/availability_strategy.py      10      0   100%
source_freshdesk/__init__.py                    2      0   100%
source_freshdesk/streams.py                   224      4    98%
source_freshdesk/utils.py                      20      1    95%
---------------------------------------------------------------
TOTAL                                         278      5    98%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 508.18s (0:08:28) ===================

davydov-d · 2023-05-09T12:54:16Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4925928108

davydov-d · 2023-05-09T12:54:22Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4925927980
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4925927980
🐛 https://gradle.com/s/vh6x5tgod2rgu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 5 failed, 34 passed, 2 skipped in 49.36s ===================

davydov-d · 2023-05-09T12:54:30Z

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/4925928928
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/4925928928
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pinterest/utils.py          8      0   100%
source_pinterest/__init__.py       2      0   100%
source_pinterest/source.py       224     17    92%
--------------------------------------------------
TOTAL                            234     17    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 49 passed, 1 skipped in 215.28s (0:03:35) ===================

davydov-d · 2023-05-09T14:06:19Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4926723395
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4926723395
🐛 https://gradle.com/s/jop5lyvmrcdys

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream activ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 38 passed, 2 skipped in 133.90s (0:02:13) ==============

airbyte-integrations/connectors/source-pipedrive/source_pipedrive/streams.py

airbyte-integrations/connectors/source-pinterest/source_pinterest/schemas/board_pins.json

davydov-d · 2023-05-09T14:53:07Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4927228400
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4927228400
🐛 https://gradle.com/s/pdgryr4fhigv2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream activ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 38 passed, 2 skipped in 138.81s (0:02:18) ==============

davydov-d · 2023-05-09T16:22:42Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4928132377
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4928132377
🐛 https://gradle.com/s/aszxt6ygwataq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream deals...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 38 passed, 2 skipped in 134.64s (0:02:14) ==============

davydov-d · 2023-05-10T08:01:58Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4934569994
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4934569994
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/auth.py           8      0   100%
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        38      2    95%
source_pipedrive/streams.py      101     15    85%
--------------------------------------------------
TOTAL                            149     17    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 2 skipped in 220.30s (0:03:40) ===================

davydov-d · 2023-05-10T16:38:48Z

@erohmensing I've excluded Pipedrive changes from this PR as we talked before

erohmensing · 2023-05-10T17:15:51Z

Thanks! Other changes look good

davydov-d · 2023-05-11T04:16:09Z

/publish connector=connectors/pinterest

🕑 Publishing the following connectors:
connectors/pinterest
https://github.com/airbytehq/airbyte/actions/runs/4943897693

Connector	Version	Did it publish?	Were definitions generated?
connectors/pinterest		❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-05-11T04:24:26Z

/publish connector=connectors/source-pinterest

🕑 Publishing the following connectors:
connectors/source-pinterest
https://github.com/airbytehq/airbyte/actions/runs/4943941320

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-pinterest	0.3.0	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…rbytehq#25915) * #connector health: fix builds for pipedrive, mixpanel, freshdesk, pinterest * Source Pipedrive: another fix * Source Pipedrive: another fix * Source Pipedrive: another fix * Source Pipedrive: update expected records * connector health: upd changelogs * connector health: exclude pipedrive changes for now * connector health: exclude pipedrive changes for now * connector health: exclude pipedrive changes for now * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

#connector health: fix builds for pipedrive, mixpanel, freshdesk, pin…

91a1be9

…terest

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel connectors/source/freshdesk connectors/source/pinterest connectors/source/pipedrive labels May 9, 2023

davydov-d changed the title ~~#connector health: fix builds for pipedrive, mixpanel, freshdesk, pin…~~ 🐛 Source Mixpanel, Source Pipedrive, Source Pinterest, Source Freshdesk: fix builds May 9, 2023

Source Pipedrive: another fix

d18b74e

davydov-d requested review from grubberr, erohmensing and lazebnyi May 9, 2023 14:07

erohmensing requested changes May 9, 2023

View reviewed changes

airbyte-integrations/connectors/source-pipedrive/source_pipedrive/streams.py Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-pinterest/source_pinterest/schemas/board_pins.json Show resolved Hide resolved

davydov-d requested a review from erohmensing May 9, 2023 14:45

Source Pipedrive: another fix

2b822dd

Source Pipedrive: another fix

f294416

Source Pipedrive: update expected records

fa6be4f

davydov-d added 4 commits May 10, 2023 13:15

connector health: upd changelogs

7a4ddfa

connector health: exclude pipedrive changes for now

6aa190b

connector health: exclude pipedrive changes for now

5137bf8

connector health: exclude pipedrive changes for now

1e1a3e4

erohmensing approved these changes May 10, 2023

View reviewed changes

erohmensing changed the title ~~🐛 Source Mixpanel, Source Pipedrive, Source Pinterest, Source Freshdesk: fix builds~~ 🐛 Source Mixpanel, Source Pinterest, Source Freshdesk: fix builds May 10, 2023

lazebnyi approved these changes May 10, 2023

View reviewed changes

auto-bump connector version

d37398f

davydov-d added the checklist-action-run label May 11, 2023

davydov-d merged commit ac154b1 into master May 11, 2023

davydov-d deleted the ddavydov/connector-health branch May 11, 2023 05:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Mixpanel, Source Pinterest, Source Freshdesk: fix builds #25915

🐛 Source Mixpanel, Source Pinterest, Source Freshdesk: fix builds #25915

davydov-d commented May 9, 2023 •

edited

Loading

github-actions bot commented May 9, 2023 •

edited by davydov-d

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 10, 2023

erohmensing commented May 10, 2023

davydov-d commented May 11, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 11, 2023 •

edited by github-actions bot

Loading

🐛 Source Mixpanel, Source Pinterest, Source Freshdesk: fix builds #25915

🐛 Source Mixpanel, Source Pinterest, Source Freshdesk: fix builds #25915

Conversation

davydov-d commented May 9, 2023 • edited Loading

What

How

github-actions bot commented May 9, 2023 • edited by davydov-d Loading

Before Merging a Connector Pull Request

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented May 9, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented May 10, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented May 10, 2023

erohmensing commented May 10, 2023

davydov-d commented May 11, 2023 • edited by github-actions bot Loading

davydov-d commented May 11, 2023 • edited by github-actions bot Loading

davydov-d commented May 9, 2023 •

edited

Loading

github-actions bot commented May 9, 2023 •

edited by davydov-d

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 11, 2023 •

edited by github-actions bot

Loading

davydov-d commented May 11, 2023 •

edited by github-actions bot

Loading