Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Gitlab, Source Hubspot, Source Snapchat-Marketing: fix builds #25948

Merged
merged 7 commits into from
May 11, 2023
Merged

🐛 Source Gitlab, Source Hubspot, Source Snapchat-Marketing: fix builds #25948

merged 7 commits into from
May 11, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 10, 2023 •
edited
Loading

What

Fix builds for:

  • Hubspot. For stream Tickets, one property was removed: hs_all_assigned_business_unit_ids
  • Gitlab. Some records have been changed in Projects stream. New fields appeared: description_html, updated_at
  • Snapchat-marketing. Some records have been changed in Campaigns stream. New field appeared: creation_state

How

  • Hubspot: Update expected records only, since the properties for tickets stream are dynamically updated in schema, based on authenticated user, account plan and permissions.
  • Gitlab: Update expected records, update stream schema, bump version.
  • Snapchat-marketing: Update expected records, update stream schema, bump version

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023 •
edited by davydov-d
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 10, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4935201442
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4935201442
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py         10      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       897     77    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                          1041     99    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/errors.py         10      1    90%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       897    217    76%
-------------------------------------------------
TOTAL                          1041    239    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 371.36s (0:06:11) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 10, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/4935205086

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 10, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4935206366
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4935206366
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       284     22    92%
-----------------------------------------------------------
TOTAL                                     286     22    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 44 passed, 1 skipped in 480.35s (0:08:00) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 10, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/4935594492
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/4935594492
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gitlab/__init__.py       2      0   100%
source_gitlab/source.py        61      3    95%
source_gitlab/streams.py      279     15    95%
-----------------------------------------------
TOTAL                         342     18    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 44 passed, 1 skipped in 561.83s (0:09:21) ===================

@davydov-d davydov-d changed the title Connector health: source hubspot, gitlab, snapchat-marketing: fix builds 🐛 Source Gitlab, Source Hubspot, Source Snapchat-Marketing: fix builds May 10, 2023
@davydov-d davydov-d marked this pull request as ready for review May 10, 2023 10:10
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 10, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/4937945819


Connector Version Did it publish? Were definitions generated?
connectors/source-gitlab 1.1.0 ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 10, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-snapchat-marketing

🕑 Publishing the following connectors:
connectors/source-snapchat-marketing
https://github.com/airbytehq/airbyte/actions/runs/4937947709


Connector Version Did it publish? Were definitions generated?

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

🕑 Publishing the following connectors:
connectors/source-snapchat-marketing
https://github.com/airbytehq/airbyte/actions/runs/4937947709


Connector Version Did it publish? Were definitions generated?
connectors/source-snapchat-marketing 0.2.0 ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

erohmensing
erohmensing approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for laying out what changed and how you fixed it in the PR description. Made the review super easy!

@davydov-d davydov-d merged commit 0bab0b6 into master May 11, 2023
21 checks passed
@davydov-d davydov-d deleted the ddavydov/source-hubspot-gitlab-snapchat-fix-builds branch May 11, 2023 04:40
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@davydov-d @octavia-squidington-iii @marcosmarxm
🐛 Source Gitlab, Source Hubspot, Source Snapchat-Marketing: fix builds (
c904847 
airbytehq#25948)

* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* connector health: upd changelogs

* auto-bump connector version

* #connector health: update snapchat definition manually

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@erohmensing erohmensing erohmensing approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/gitlab connectors/source/hubspot connectors/source/snapchat-marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davydov-d @grubberr @erohmensing @lazebnyi @octavia-squidington-iii