Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Close-Come, Source Hubspot, Source GitHub, Source TikTok-Marketing, Source SurveyMonkey, Source SmartSheets: fix builds #26024

Merged
merged 11 commits into from
May 12, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 12, 2023

What

Fix builds for:

  • Source close-com: expected records mismatch because of a new field shown up in a EmailSequences stream
  • Source tiktok-marketing: expected records mismatch because of a new field shown up in a Ads stream
  • Source hubspot: expected records mismatch because of a new field shown up in a EngagementsTasks stream
  • Source github: expected records mismatch because datetime fields returned in a different timezone (stream workflows)
  • Source smartsheets: failure during read because of a dependencies conflict
  • Source surveymonkey: failure during read because of a dependencies conflict

How

  • Source close-com: update expected records, update stream schema, bump version, update changelog
  • Source tiktok-marketing: update expected records, update stream schema, bump version, update changelog
  • Source hubspot: update expected records
  • Source github: update CAT config to ignore datetime fields in a particular stream
  • Source smartsheets: specify dependency version in setup.py, bump version, update changelog
  • Source surveymonkey: specify dependency version in setup.py, bump version, update changelog

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 12, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4957671681
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4957671681
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_smartsheets/source.py        13      0   100%
source_smartsheets/__init__.py       2      0   100%
source_smartsheets/sheet.py         79      4    95%
source_smartsheets/streams.py       37      4    89%
----------------------------------------------------
TOTAL                              131      8    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================= 39 passed, 2 skipped, 40 warnings in 26.22s ==================

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4957672418
❌ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4957672418
🐛 https://gradle.com/s/o7pxxmdl36nta

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs2] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs0]
ERROR test_core.py::TestSpec::test_config_match_spec[inputs0] - docker.errors...
ERROR test_core.py::TestSpec::test_match_expected[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_docker_env[inputs0] - docker.errors.Contai...
ERROR test_core.py::TestSpec::test_enum_usage[inputs0] - docker.errors.Contai...
ERROR test_core.py::TestSpec::test_oneof_usage[inputs0] - docker.errors.Conta...
ERROR test_core.py::TestSpec::test_secret_is_properly_marked[inputs0] - docke...
ERROR test_core.py::TestSpec::test_defined_refs_exist_in_json_spec_file[inputs0]
ERROR test_core.py::TestSpec::test_oauth_flow_parameters[inputs0] - docker.er...
ERROR test_core.py::TestSpec::test_backward_compatibility[inputs0] - docker.e...
ERROR test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - d...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 5 failed, 13 passed, 23 errors in 18.24s ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4957674285
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4957674285
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py         10      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       897     77    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                          1041     99    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/errors.py         10      1    90%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       897    217    76%
-------------------------------------------------
TOTAL                          1041    239    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 372.51s (0:06:12) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-close-com

🕑 connectors/source-close-com https://github.com/airbytehq/airbyte/actions/runs/4957676078
✅ connectors/source-close-com https://github.com/airbytehq/airbyte/actions/runs/4957676078
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 39 passed, 1 skipped in 386.74s (0:06:26) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4957677456

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4957679417
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4957679417
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/utils.py              16      1    94%
source_github/streams.py           838     91    89%
source_github/graphql.py           167     22    87%
source_github/source.py            134     35    74%
----------------------------------------------------
TOTAL                             9964    149    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 47 passed, 3 skipped in 312.72s (0:05:12) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/4957682131
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/4957682131
🐛 https://gradle.com/s/iamjxo5dl5slk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: At l...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 5 failed, 34 passed, 1 skipped in 480.40s (0:08:00) ==============

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4957822419
✅ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4957822419
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_surveymonkey/__init__.py       2      0   100%
source_surveymonkey/streams.py      158     15    91%
source_surveymonkey/source.py        65     13    80%
-----------------------------------------------------
TOTAL                               225     28    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 2 skipped in 263.48s (0:04:23) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4957823179
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4957823179
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_smartsheets/source.py        13      0   100%
source_smartsheets/__init__.py       2      0   100%
source_smartsheets/sheet.py         79      4    95%
source_smartsheets/streams.py       37      4    89%
----------------------------------------------------
TOTAL                              131      8    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================= 39 passed, 2 skipped, 40 warnings in 26.53s ==================

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4958028563
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4958028563
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_tiktok_marketing/__init__.py       2      0   100%
source_tiktok_marketing/source.py        68      7    90%
source_tiktok_marketing/streams.py      382     41    89%
---------------------------------------------------------
TOTAL                                   452     48    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 91 passed, 2 skipped in 1720.59s (0:28:40) ==================

@davydov-d davydov-d changed the title Ddavydov/connector health 2023 05 12 🐛 Source Close-Come, Source Hubspot, Source GitHub, Source TikTok-Marketing, Source SurveyMonkey, Source SmartSheets: fix builds May 12, 2023
@davydov-d davydov-d requested a review from lazebnyi May 12, 2023 13:41
@davydov-d davydov-d marked this pull request as ready for review May 12, 2023 13:41
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/publish connector=connectors/source-surveymonkey

🕑 Publishing the following connectors:
connectors/source-surveymonkey
https://github.com/airbytehq/airbyte/actions/runs/4960681355


Connector Version Did it publish? Were definitions generated?
connectors/source-surveymonkey 0.2.2

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/publish connector=connectors/source-smartsheets

🕑 Publishing the following connectors:
connectors/source-smartsheets
https://github.com/airbytehq/airbyte/actions/runs/4960682279


Connector Version Did it publish? Were definitions generated?
connectors/source-smartsheets 1.0.2

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/publish connector=connectors/source-close-com

🕑 Publishing the following connectors:
connectors/source-close-com
https://github.com/airbytehq/airbyte/actions/runs/4960683079


Connector Version Did it publish? Were definitions generated?
connectors/source-close-com 0.3.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2023

/publish connector=connectors/source-tiktok-marketing

🕑 Publishing the following connectors:
connectors/source-tiktok-marketing
https://github.com/airbytehq/airbyte/actions/runs/4960683533


Connector Version Did it publish? Were definitions generated?
connectors/source-tiktok-marketing 3.1.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 84fd8a5 into master May 12, 2023
20 of 22 checks passed
@davydov-d davydov-d deleted the ddavydov/connector-health-2023-05-12 branch May 12, 2023 20:10
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…keting, Source SurveyMonkey, Source SmartSheets: fix builds (airbytehq#26024)

* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* fix builds

* resolve dependencies conflict, bump version

* tiktok: upd expected records

* connector health: revert GA4 changes

* auto-bump connector version

* connector health: upd source definitions manually

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants