New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Github: better error explanation for 401 #26025
Source Github: better error explanation for 401 #26025
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-github
Build FailedTest summary info:
|
/test connector=connectors/source-github
Build FailedTest summary info:
|
/test connector=connectors/source-github
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update description to what and how master will be changed with your PR.
airbyte-integrations/connectors/source-github/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-github/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
4418584
to
6495726
Compare
/publish connector=connectors/source-github
if you have connectors that successfully published but failed definition generation, follow step 4 here |
876fd9d
to
43dbbd5
Compare
/publish connector=connectors/source-github
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* Source Github: better error explanation for 401 * Source Github: bump version, update changelog * Source Github: fix test name * Source Github: fix unittests * Source Github: bump version * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Not every case handled when 401 exception happen. Unhandled 401 error gives traceback instead of human readable error description.
How
*Added log with more transparent depiction of the personal access token expired instead of just getting error traceback. For this I made the following changes:
<token type> renewal is required: <original error message>
. Of course I raise original error in the end to do not break the flow_get_authenticator
method become not static, soSourceGithub
need to be instantiated now to call it