connectors-ci: check if the pushed image can be pulled #26088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnchrch
approved these changes
May 15, 2023
|
|
||
| async def _run(self) -> StepResult: | ||
| try: | ||
| exit_code = await with_exit_code( |
There was a problem hiding this comment.
Do we need any retry logic?
The steps are sequential so I have the guarantee docker push happenned before docker pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#26085 suggests that published images might very rarely not be pullable.
I'd like to add a safety net on the publish flow and to always pull images that were just pushed and try to run SPEC on them.
The networking overhead is worth the peace of mind IMO.
How
Bonus: do not try to upload metadata or spec cache during a pre-release flow.