Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update low-code reference docs to mention that %s should be used for unix timestamp #26096

Merged
merged 5 commits into from
May 23, 2023
Merged

Update low-code reference docs to mention that %s should be used for unix timestamp #26096

merged 5 commits into from
May 23, 2023

Conversation

girarda
Copy link
Contributor

@girarda girarda commented May 15, 2023 •
edited

What

  • Update low-code reference docs to mention that `%s should be used to format timestamps

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 15, 2023
@girarda girarda marked this pull request as ready for review May 15, 2023 21:54
@girarda girarda requested a review from a team as a code owner May 15, 2023 21:54
@girarda girarda requested a review from flash1293 May 15, 2023 21:54
@girarda girarda changed the title Mention that %s should be used for unix timestamp Update low-code reference docs to mention that %s should be used for unix timestamp May 15, 2023
flash1293
flash1293 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we also add it to the list of suggested options in the frontend?

@girarda girarda merged commit fa626c6 into master May 23, 2023
17 checks passed
@girarda girarda deleted the alex/update_timestamp_description branch May 23, 2023 00:05
nguyenaiden pushed a commit that referenced this pull request May 25, 2023
@girarda @nguyenaiden
Update low-code reference docs to mention that %s should be used for …
5c493ee 
…unix timestamp (#26096)

* Mention that %s should be used for unix timestamp

* update docs and add unit test

* Update test

* Update
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@girarda @marcosmarxm
Update low-code reference docs to mention that %s should be used for …
f568b70 
…unix timestamp (airbytehq#26096)

* Mention that %s should be used for unix timestamp

* update docs and add unit test

* Update test

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@girarda @flash1293 @sherifnada @octavia-squidington-iii