Source Google Sheets: handle config errors #26097

artem1205 · 2023-05-15T21:56:39Z

What

Resolve #25691

How

change error message and type to config_error

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

github-actions · 2023-05-15T21:57:03Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

artem1205 · 2023-05-15T21:59:45Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4985548905
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4985548905
🐛 https://gradle.com/s/vbpai2etjwhzc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs3] - docker.errors.Cont...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 36 passed, 3 skipped in 109.14s (0:01:49) ==============

artem1205 · 2023-05-16T09:06:55Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4990004231
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4990004231
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_sheets/models/spreadsheet_values.py      12      0   100%
source_google_sheets/models/spreadsheet.py             34      0   100%
source_google_sheets/models/__init__.py                 2      0   100%
source_google_sheets/__init__.py                        2      0   100%
source_google_sheets/utils.py                          23      1    96%
source_google_sheets/helpers.py                       145     27    81%
source_google_sheets/client.py                         23      6    74%
source_google_sheets/source.py                        115     90    22%
-----------------------------------------------------------------------
TOTAL                                                 356    124    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 37 passed, 3 skipped in 148.65s (0:02:28) ===================

lazebnyi

LGTM. Need add unit tests.

lazebnyi · 2023-05-16T10:20:03Z

airbyte-integrations/connectors/source-google-sheets/source_google_sheets/source.py

-                status=Status.FAILED, message=f"Unable to connect with the provided credentials to spreadsheet. Error: {reason}"
-            )
+                message += "The spreadsheet link is not valid. Enter the URL of the Google spreadsheet you want to sync."
+            raise AirbyteTracedException(


Can we add unit tests.

tests added

artem1205 · 2023-05-16T15:46:42Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4994010262
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4994010262
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_sheets/models/spreadsheet_values.py      12      0   100%
source_google_sheets/models/spreadsheet.py             34      0   100%
source_google_sheets/models/__init__.py                 2      0   100%
source_google_sheets/__init__.py                        2      0   100%
source_google_sheets/utils.py                          23      1    96%
source_google_sheets/helpers.py                       145     21    86%
source_google_sheets/client.py                         23      5    78%
source_google_sheets/source.py                        115     75    35%
-----------------------------------------------------------------------
TOTAL                                                 356    102    71%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 37 passed, 3 skipped in 132.76s (0:02:12) ===================

artem1205 · 2023-05-16T17:41:20Z

/publish connector=connectors/source-google-sheets

🕑 Publishing the following connectors:
connectors/source-google-sheets
https://github.com/airbytehq/airbyte/actions/runs/4995048031

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-google-sheets	0.2.38	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…rs-25691 # Conflicts: # airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json # airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml # airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml

* Source Google Sheets: handle config errors * Source Google Sheets: update docs * Source Google Sheets: fix test * Source Google Sheets: add unit tests * auto-bump connector version * Automated Change --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: artem1205 <artem1205@users.noreply.github.com>

Source Google Sheets: handle config errors

c10b145

octavia-squidington-iii added area/connectors Connector related issues connectors/source/google-sheets labels May 15, 2023

Source Google Sheets: update docs

aba725d

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 15, 2023

Source Google Sheets: fix test

d7f35a8

artem1205 requested review from grubberr and lazebnyi May 16, 2023 09:19

lazebnyi approved these changes May 16, 2023

View reviewed changes

Source Google Sheets: add unit tests

431fd04

octavia-squidington-iii and others added 5 commits May 16, 2023 17:57

auto-bump connector version

46d67f2

Automated Change

848c119

Empty-Commit

29f1fa0

Empty-Commit

76fbb98

artem1205 merged commit 0eefa33 into master May 16, 2023
15 of 17 checks passed

artem1205 deleted the artem1205/source-google-sheets-config-errors-25691 branch May 16, 2023 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Google Sheets: handle config errors #26097

Source Google Sheets: handle config errors #26097

artem1205 commented May 15, 2023

github-actions bot commented May 15, 2023 •

edited by artem1205

Loading

artem1205 commented May 15, 2023 •

edited by github-actions bot

Loading

artem1205 commented May 16, 2023 •

edited by github-actions bot

Loading

lazebnyi left a comment

lazebnyi May 16, 2023

artem1205 May 16, 2023

artem1205 commented May 16, 2023 •

edited by github-actions bot

Loading

artem1205 commented May 16, 2023 •

edited by github-actions bot

Loading

Source Google Sheets: handle config errors #26097

Source Google Sheets: handle config errors #26097

Conversation

artem1205 commented May 15, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

github-actions bot commented May 15, 2023 • edited by artem1205 Loading

Before Merging a Connector Pull Request

artem1205 commented May 15, 2023 • edited by github-actions bot Loading

Build Failed

artem1205 commented May 16, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi left a comment

Choose a reason for hiding this comment

lazebnyi May 16, 2023

Choose a reason for hiding this comment

artem1205 May 16, 2023

Choose a reason for hiding this comment

artem1205 commented May 16, 2023 • edited by github-actions bot Loading

Build Passed

artem1205 commented May 16, 2023 • edited by github-actions bot Loading

github-actions bot commented May 15, 2023 •

edited by artem1205

Loading

artem1205 commented May 15, 2023 •

edited by github-actions bot

Loading

artem1205 commented May 16, 2023 •

edited by github-actions bot

Loading

artem1205 commented May 16, 2023 •

edited by github-actions bot

Loading

artem1205 commented May 16, 2023 •

edited by github-actions bot

Loading