Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Update QA engine to use metadata to unblock PR #26098

Merged
merged 2 commits into from
May 15, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented May 15, 2023

What

A few problems coincided

  1. QA engine relies on the definition files.
  2. In the past source/destiantion masks added connectors to cloud without the knowledge of the qa engine
  3. The tests for QA engine have not been running.

blocks this PR from running: #26094

Solution

update qa engine to use metadat ahead of large cut over

Will be cowboy merging this 馃

@bnchrch bnchrch requested a review from alafanechere May 15, 2023 22:36
@bnchrch
Copy link
Contributor Author

bnchrch commented May 15, 2023

/approve-and-merge reason="qa-engine unblock"

@octavia-approvington
Copy link
Contributor

Lets merge it
sheep thumbs up

@octavia-approvington octavia-approvington merged commit d201851 into master May 15, 2023
13 checks passed
@octavia-approvington octavia-approvington deleted the bnchrch/qa-engine-fix-metadata branch May 15, 2023 22:38
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants