connectors-ci: use crane to check if image exists #26118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnchrch
approved these changes
May 16, 2023
| @@ -716,3 +716,7 @@ def with_airbyte_python_connector_full_dagger(context: ConnectorContext, build_p | |||
| .with_label("io.airbyte.version", context.metadata["dockerImageTag"]) | |||
| .with_label("io.airbyte.name", context.metadata["dockerRepository"]) | |||
| ) | |||
|
|
|||
|
|
|||
| def with_crane(context: PipelineContext) -> Container: | |||
There was a problem hiding this comment.
nit: lets link to the crane docs here and talk about why crane
alafanechere
deleted the
augustin/connectors-ci/use-crane-to-check-image-exists
branch
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
craneis a cool tool to inspect docker registry images. It's actively use by the dagger team for investigation.It has the benefit of not requiring a docker daemon to run.
I want to replace the use of docker cli by crane in the
CheckConnectorImageDoesNotExiststep to not rely on docker in docker pattern that can be unstable ( see #25877)How
No logical change == no test change == the test are still passing:
crane lsto check the tag available in an image repocrane lscommand failed we mark the step as FAILURE and push won't hapen