Source File Secure: bump source-file version 0.2.38 -> 0.3.7 #26131

grubberr · 2023-05-16T17:34:54Z

What

I want to re-publish source-file and source-file-secure because
source-file-secure is based on top of out-dated version of source-file:0.2.38

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions · 2023-05-16T17:35:13Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

grubberr · 2023-05-16T17:36:45Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/4995014764

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-file-secure	0.3.6	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2023-05-16T17:50:32Z

already done here 59903d0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bnchrch · 2023-05-16T20:42:10Z

Hey @grubberr! Just looking at this now.

Im sorry we missed the version at the top of the dockerfile!

I think youre going the correct way and updating both to 0.3.7 to accomodate.

bnchrch · 2023-05-16T20:42:43Z

airbyte-integrations/connectors/source-file/metadata.yaml

@@ -5,7 +5,7 @@ data:
  connectorSubtype: file
  connectorType: source
  definitionId: 778daa7c-feaf-4db6-96f3-70fd645acc77
-  dockerImageTag: 0.3.6
+  dockerImageTag: 0.3.7


We also need to update the cloud pinned version

https://github.com/airbytehq/airbyte/pull/26131/files#diff-580b4a25c9d6e8ce3172870d4a6eb1064426fc4c557c69b90361902bc66d39dfL17

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bnchrch

LGTM! Just make sure to run /publish for both source-file and source-file-secure

grubberr · 2023-05-16T21:02:54Z

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/4996691319

Connector	Version	Did it publish?	Were definitions generated?

grubberr · 2023-05-16T21:52:57Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/4997010068

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-file-secure	0.3.7	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-05-16T22:52:51Z

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/4997401686
✅ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/4997401686
Python tests coverage:

Name                                                                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------------------------------------------------------
source_file_secure/__init__.py                                                                                  2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/__init__.py       2      0   100%
source_file_secure/source.py                                                                                   45     10    78%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/utils.py         13      5    62%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/source.py        83     48    42%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/client.py       330    251    24%
-------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                         475    314    34%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================= 36 passed, 3 skipped, 38 warnings in 56.12s ==================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bnchrch · 2023-05-16T23:10:26Z

Hey @grubberr

Ok so I noticed that the source-file-secure is not publishing because its spec tests are failing
https://scans.gradle.com/s/pfciulrg3tgr2/console-log?task=:airbyte-integrations:connectors:source-file-secure:connectorAcceptanceTest

To resolve this I think we have two choices

Fix the spec in the source-file-secure

Wait, nvm, I see you just did that! Woohoo!

bnchrch · 2023-05-16T23:11:00Z

Next onto the failing definitions.

That was my fault. Weve removed the auto bump feature. And /publish still references it.

Ill remove that ASAP

grubberr · 2023-05-16T23:21:47Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/4997592733

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-file-secure	0.3.7	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…hq#26131) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump 0.3.6

835e42a

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this May 16, 2023

octavia-squidington-iii added the area/connectors Connector related issues label May 16, 2023

octavia-squidington-iii added the connectors/source/file-secure label May 16, 2023

grubberr requested a review from artem1205 May 16, 2023 17:35

artem1205 approved these changes May 16, 2023

View reviewed changes

grubberr closed this May 16, 2023

grubberr reopened this May 16, 2023

grubberr added 2 commits May 16, 2023 20:13

Merge branch 'master' into grubberr/oncall-1954-source-file-secure

7227f2e

bump version 0.3.6

acc4be6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr changed the title ~~Source File Secure: add retry on SSHException('Error reading SSH protocol banner')~~ Source File Secure: bump source-file version 0.2.38 -> 0.3.6 May 16, 2023

grubberr requested review from bnchrch and artem1205 May 16, 2023 20:15

bump 0.3.7

c0dd753

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the connectors/source/file label May 16, 2023

grubberr changed the title ~~Source File Secure: bump source-file version 0.2.38 -> 0.3.6~~ Source File Secure: bump source-file version 0.2.38 -> 0.3.7 May 16, 2023

file.md updated

3c13591

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 16, 2023

grubberr requested review from erohmensing, evantahler and lazebnyi May 16, 2023 20:31

evantahler approved these changes May 16, 2023

View reviewed changes

Automated Change

a7f345f

bnchrch reviewed May 16, 2023

View reviewed changes

bazarnov approved these changes May 16, 2023

View reviewed changes

bump 0.3.7

45bbd37

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from bnchrch May 16, 2023 21:01

bnchrch approved these changes May 16, 2023

View reviewed changes

Automated Change

d0bd842

spec.json fixed

c4effa6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 3 commits May 16, 2023 23:04

recover from master

bd0394b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/oncall-1954-source-file-secure

027bc4f

oss_registry.json updated

1ce7d50

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit 033e62a into master May 16, 2023

grubberr deleted the grubberr/oncall-1954-source-file-secure branch May 16, 2023 23:44

marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023

Source File Secure: bump source-file version 0.2.38 -> 0.3.7 (airbyte…

1cb757b

…hq#26131) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source File Secure: bump source-file version 0.2.38 -> 0.3.7 #26131

Source File Secure: bump source-file version 0.2.38 -> 0.3.7 #26131

grubberr commented May 16, 2023 •

edited

Loading

github-actions bot commented May 16, 2023 •

edited by grubberr

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023

bnchrch commented May 16, 2023

bnchrch May 16, 2023

bnchrch left a comment

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

bnchrch commented May 16, 2023

bnchrch commented May 16, 2023

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

Source File Secure: bump source-file version 0.2.38 -> 0.3.7 #26131

Source File Secure: bump source-file version 0.2.38 -> 0.3.7 #26131

Conversation

grubberr commented May 16, 2023 • edited Loading

What

github-actions bot commented May 16, 2023 • edited by grubberr Loading

Before Merging a Connector Pull Request

grubberr commented May 16, 2023 • edited by github-actions bot Loading

grubberr commented May 16, 2023

bnchrch commented May 16, 2023

bnchrch May 16, 2023

Choose a reason for hiding this comment

bnchrch left a comment

Choose a reason for hiding this comment

grubberr commented May 16, 2023 • edited by github-actions bot Loading

grubberr commented May 16, 2023 • edited by github-actions bot Loading

grubberr commented May 16, 2023 • edited by github-actions bot Loading

Build Passed

bnchrch commented May 16, 2023

bnchrch commented May 16, 2023

grubberr commented May 16, 2023 • edited by github-actions bot Loading

grubberr commented May 16, 2023 •

edited

Loading

github-actions bot commented May 16, 2023 •

edited by grubberr

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading

grubberr commented May 16, 2023 •

edited by github-actions bot

Loading