Metadata: Check that normalized files exist #26133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnchrch
force-pushed
the
bnchrch/metadata/check-normalization
branch
from
efc679c
to
b938ede
Compare
alafanechere
approved these changes
May 19, 2023
airbyte-ci/connectors/metadata_service/lib/tests/fixtures/__init__.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/metadata_service/lib/tests/fixtures/__init__.py
Outdated
Show resolved
Hide resolved
| return "exists" in image_name and "exists" in version | ||
|
|
||
|
|
||
| def setup_upload_mocks(mocker, version_blob_md5_hash, latest_blob_md5_hash, local_file_md5_hash): |
There was a problem hiding this comment.
nit: in pytest the setup teardown pattern is usually declared through the use of fixtures.
Co-authored-by: Augustin <augustin@airbyte.io>
bnchrch
force-pushed
the
bnchrch/metadata/check-normalization
branch
from
1173ed6
to
5627a63
Compare
nguyenaiden
pushed a commit
that referenced
this pull request
May 25, 2023
* Check that normalized files exist * refactor fixtures * Mocks * Update tests * Format * Apply suggestions from code review Co-authored-by: Augustin <augustin@airbyte.io> * Revert path --------- Co-authored-by: Augustin <augustin@airbyte.io>
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
* Check that normalized files exist * refactor fixtures * Mocks * Update tests * Format * Apply suggestions from code review Co-authored-by: Augustin <augustin@airbyte.io> * Revert path --------- Co-authored-by: Augustin <augustin@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checks that the normalization images exist on metadata file upload
and adds tests to ensure were doing this check
closes #25538