-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Source Slack: limit the lookback window
range to prevent Overflow
with dates
#26186
π Source Slack: limit the lookback window
range to prevent Overflow
with dates
#26186
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! π To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Closing and re-opening to unfreeze the CI checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Feel free to merge once the /test pass.
/test connector=connectors/source-slack
Build PassedTest summary info:
|
/publish connector=connectors/source-slack
| Connector | Version | Did it publish? | if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Resolving: https://github.com/airbytehq/oncall/issues/1971
How
spec.json
to limit thelookback window
range in days as follows:β User Impact Level β : Non Breaking
This is not a breaking change unless existing users have anything above
365
for theirlookback window
value in the input config.Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes