Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Source Slack: limit the lookback window range to prevent Overflow with dates #26186

Merged
merged 3 commits into from
May 17, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented May 17, 2023

What

Resolving: https://github.com/airbytehq/oncall/issues/1971

How

  • adjusted spec.json to limit the lookback window range in days as follows:
min: 0,
default: 0,
max: 365

βœ… User Impact Level βœ… : Non Breaking

This is not a breaking change unless existing users have anything above 365 for their lookback window value in the input config.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! πŸŽ‰

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 17, 2023
@alafanechere
Copy link
Contributor

Closing and re-opening to unfreeze the CI checks.

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Feel free to merge once the /test pass.

@alafanechere
Copy link
Contributor

alafanechere commented May 17, 2023

/test connector=connectors/source-slack

πŸ•‘ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/5003037156
βœ… connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/5003037156
Python tests coverage:

Name                       Stmts   Miss  Cover
----------------------------------------------
source_slack/__init__.py       2      0   100%
source_slack/source.py       225     19    92%
----------------------------------------------
TOTAL                        227     19    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 843.76s (0:14:03) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented May 17, 2023

/publish connector=connectors/source-slack

πŸ•‘ Publishing the following connectors:
connectors/source-slack
https://github.com/airbytehq/airbyte/actions/runs/5003253324


| Connector | Version | Did it publish? |
| --- | --- | --- | --- |
| connectors/source-slack | 0.1.26 | βœ… |

if you have connectors that successfully published but failed definition generation, follow step 4 here ▢️

@bazarnov bazarnov merged commit a6dfbeb into master May 17, 2023
24 checks passed
@bazarnov bazarnov deleted the baz/source-slack-fix-lookback-window-overflow branch May 17, 2023 13:04
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants