🐛 Source Hubspot, Gitlab, Salesloft, Pinterest: fix builds #26188

davydov-d · 2023-05-17T13:34:26Z

What

Fix builds for:

Source Hubspot. Expected and actual records mismatch of the Deals stream - new property added - hs_closed_won_count, value of the property hs_time_in_appointmentscheduled updated.
Source Gitlab. Expected and actual records mismatch of the Jobs stream - value of the property runner_id updated.
Source Salesloft. Expected and actual records mismatch of the Cadences stream - new property added - latest_active_date.
Source Pinterest. Expected and actual records mismatch of the BoardPins stream - new property added - product_tags.

How

Source Hubspot: update expected records. No need to update stream schema as it is generated dynamically.
Source Gitlab: update expected records.
Source Salesloft: udate expected records, update stream schema, bump version, update changelog.
Source Pinterest: udate expected records, update stream schema, bump version, update changelog.

davydov-d · 2023-05-17T13:34:41Z

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5003876906
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5003876906
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gitlab/__init__.py       2      0   100%
source_gitlab/source.py        61      3    95%
source_gitlab/streams.py      279     15    95%
-----------------------------------------------
TOTAL                         342     18    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 43 passed, 2 skipped in 571.04s (0:09:31) ===================

github-actions · 2023-05-17T13:34:47Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

davydov-d · 2023-05-17T13:34:48Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5003877980
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5003877980
🐛 https://gradle.com/s/khzq7f74x52hg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream deals...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 39 passed, 2 skipped in 439.27s (0:07:19) ==============

davydov-d · 2023-05-17T13:34:55Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/5003878953
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/5003878953
🐛 https://gradle.com/s/igbyusgy7hwu4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
============= 2 failed, 49 passed, 1 skipped in 172.42s (0:02:52) ==============

davydov-d · 2023-05-17T13:35:01Z

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/5003879618
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/5003879618
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pinterest/utils.py          8      0   100%
source_pinterest/__init__.py       2      0   100%
source_pinterest/source.py       224     17    92%
--------------------------------------------------
TOTAL                            234     17    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 49 passed, 1 skipped in 216.99s (0:03:36) ===================

…bytehq/airbyte into ddavydov/connector-health-2023-05-17

davydov-d · 2023-05-17T14:06:12Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/5004195120
✅ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/5004195120
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_salesloft/__init__.py       2      0   100%
source_salesloft/source.py       158      2    99%
--------------------------------------------------
TOTAL                            160      2    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 51 passed, 1 skipped in 170.69s (0:02:50) ===================

davydov-d · 2023-05-17T14:15:12Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5004294133
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/5004294133
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py         10      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       897     77    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                          1041     99    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/errors.py         10      1    90%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       897    217    76%
-------------------------------------------------
TOTAL                          1041    239    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 406.60s (0:06:46) ===================

davydov-d · 2023-05-17T14:54:01Z

/publish connector=connectors/source-pinterest

🕑 Publishing the following connectors:
connectors/source-pinterest
https://github.com/airbytehq/airbyte/actions/runs/5004710207

| Connector | Version | Did it publish? |
| --- | --- | --- | --- |
| connectors/source-pinterest | 0.5.0 | ✅ |

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-05-17T14:54:09Z

/publish connector=connectors/source-salesloft

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-05-17T15:14:17Z

/publish connector=connectors/source-salesloft

🕑 Publishing the following connectors:
connectors/source-salesloft
https://github.com/airbytehq/airbyte/actions/runs/5004935576

| Connector | Version | Did it publish? |
| --- | --- | --- | --- |
| connectors/source-salesloft | 1.1.0 | ✅ |

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds * connector health: fix builds for gitlab, salesloft, pinterest, hubspot * conenctor health: update changelog * Automated Change * connector health - fix prop type * connector health: upd expected records * Automated Change * empty commit to trigger ci --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>

…#26188) * Connector health: source hubspot, gitlab, snapchat-marketing: fix builds * connector health: fix builds for gitlab, salesloft, pinterest, hubspot * conenctor health: update changelog * Automated Change * connector health - fix prop type * connector health: upd expected records * Automated Change * empty commit to trigger ci --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>

davydov-d added 8 commits May 10, 2023 12:05

Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

92b7e1f

Merge branch 'master' of github.com:airbytehq/airbyte

01ee45e

Merge branch 'master' of github.com:airbytehq/airbyte

4ae17ec

Merge branch 'master' of github.com:airbytehq/airbyte

3fadfe3

Merge branch 'master' of github.com:airbytehq/airbyte

a51c998

Merge branch 'master' of github.com:airbytehq/airbyte

afd1fae

Merge branch 'master' of github.com:airbytehq/airbyte

72efed0

connector health: fix builds for gitlab, salesloft, pinterest, hubspot

36d38be

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 17, 2023

octavia-squidington-iii added connectors/source/hubspot connectors/source/gitlab connectors/source/pinterest connectors/source/salesloft labels May 17, 2023

conenctor health: update changelog

42f86fe

davydov-d changed the title ~~Ddavydov/connector health 2023 05 17~~ 🐛 Source Hubspot, Gitlab, Salesloft, Pinterest: fix builds May 17, 2023

davydov-d and others added 4 commits May 17, 2023 13:56

Automated Change

b15edad

connector health - fix prop type

0a0ea30

Merge branch 'ddavydov/connector-health-2023-05-17' of github.com:air…

3ecf71e

…bytehq/airbyte into ddavydov/connector-health-2023-05-17

Merge branch 'master' of github.com:airbytehq/airbyte

db47568

davydov-d added 2 commits May 17, 2023 17:07

Merge branch 'master' into ddavydov/connector-health-2023-05-17

dc07177

connector health: upd expected records

479c01e

davydov-d marked this pull request as ready for review May 17, 2023 14:30

davydov-d requested review from arsenlosenko, bazarnov, artem1205 and lazebnyi May 17, 2023 14:30

Automated Change

4682ce9

bazarnov approved these changes May 17, 2023

View reviewed changes

davydov-d added the checklist-action-run label May 17, 2023

empty commit to trigger ci

dcbd582

davydov-d merged commit 5575d86 into master May 17, 2023
23 of 26 checks passed

davydov-d deleted the ddavydov/connector-health-2023-05-17 branch May 17, 2023 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Hubspot, Gitlab, Salesloft, Pinterest: fix builds #26188

🐛 Source Hubspot, Gitlab, Salesloft, Pinterest: fix builds #26188

davydov-d commented May 17, 2023 •

edited

davydov-d commented May 17, 2023 •

edited by github-actions bot

github-actions bot commented May 17, 2023 •

edited by davydov-d

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

🐛 Source Hubspot, Gitlab, Salesloft, Pinterest: fix builds #26188

🐛 Source Hubspot, Gitlab, Salesloft, Pinterest: fix builds #26188

Conversation

davydov-d commented May 17, 2023 • edited

What

How

davydov-d commented May 17, 2023 • edited by github-actions bot

Build Passed

github-actions bot commented May 17, 2023 • edited by davydov-d

Before Merging a Connector Pull Request

davydov-d commented May 17, 2023 • edited by github-actions bot

Build Failed

davydov-d commented May 17, 2023 • edited by github-actions bot

Build Failed

davydov-d commented May 17, 2023 • edited by github-actions bot

Build Passed

davydov-d commented May 17, 2023 • edited by github-actions bot

Build Passed

davydov-d commented May 17, 2023 • edited by github-actions bot

Build Passed

davydov-d commented May 17, 2023 • edited by github-actions bot

davydov-d commented May 17, 2023 • edited by github-actions bot

davydov-d commented May 17, 2023 • edited by github-actions bot

davydov-d commented May 17, 2023 •

edited

davydov-d commented May 17, 2023 •

edited by github-actions bot

github-actions bot commented May 17, 2023 •

edited by davydov-d

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot

davydov-d commented May 17, 2023 •

edited by github-actions bot