Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSS/Cloud tags to Google Ads doc #26196

Merged
merged 2 commits into from
May 18, 2023
Merged

Add OSS/Cloud tags to Google Ads doc #26196

merged 2 commits into from
May 18, 2023

Conversation

nataliekwong
Copy link
Contributor

What

Edit Google Ads doc to contain OSS/Cloud tags to improve readability of the doc and focus Cloud users on the necessary setup components.

  • Keeps setup guide and Custom GAQL queries in Cloud
  • Removes all other sections (Supported streams, changelog)
  • Adds note at bottom that full doc can be accessed by going to docs.

@CLAassistant
Copy link

CLAassistant commented May 17, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 17, 2023
sherifnada
sherifnada approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

docs/integrations/sources/google-ads.md Outdated Show resolved Hide resolved
sherifnada
sherifnada approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

sherifnada
sherifnada approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

sherifnada
sherifnada approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

sherifnada
sherifnada approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

@nataliekwong @sherifnada
Update docs/integrations/sources/google-ads.md
e777a5d 
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@nataliekwong nataliekwong merged commit f3b2037 into master May 18, 2023
17 checks passed
@nataliekwong nataliekwong deleted the natalie/short-setup-guides branch May 18, 2023 17:39
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@nataliekwong @sherifnada @marcosmarxm
Add OSS/Cloud tags to Google Ads doc (airbytehq#26196)
3b6b0e8 
* Add OSS/Cloud tags to Google Ads doc

* Update docs/integrations/sources/google-ads.md

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

---------

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@lmossman lmossman Awaiting requested review from lmossman

@amaliaroye amaliaroye Awaiting requested review from amaliaroye

@bmcgilli bmcgilli Awaiting requested review from bmcgilli

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nataliekwong @CLAassistant @sherifnada @octavia-squidington-iii