-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source File: add retry on SSHException('Error reading SSH protocol banner') - 2 #26210
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-file
Build PassedTest summary info:
|
/publish connector=connectors/source-file
| Connector | Version | Did it publish? | if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-file-secure
| Connector | Version | Did it publish? | if you have connectors that successfully published but failed definition generation, follow step 4 here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approval: Given tests are updated, this change seems to make sense!
@@ -96,7 +96,7 @@ def close(self): | |||
|
|||
def backoff_giveup(self, error): | |||
# https://github.com/airbytehq/oncall/issues/1954 | |||
if isinstance(error, SSHException) and str(error) == "Error reading SSH protocol banner": | |||
if isinstance(error, SSHException) and str(error).startswith("Error reading SSH protocol banner"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a test changing in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improved
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
…tehq/airbyte into grubberr/oncall-1954-source-file-2
/test connector=connectors/source-file
Build PassedTest summary info:
|
…nner') - 2 (airbytehq#26210) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
What
Try to fix this oncall https://github.com/airbytehq/oncall/issues/1954
I found one bug in my prev PR #26115