🐛Source File: added parser error handling

[darynaishchenko]

What

https://github.com/airbytehq/oncall/issues/1762 #26302
Incorrect reader_options from user in config leads to ParserError: Error tokenizing data...

How

Added handling for this case of error and message to check reader options in config.

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
• You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[darynaishchenko]

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5016566974
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5016566974
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        83      7    92%
source_file/client.py       335     56    83%
---------------------------------------------
TOTAL                       433     64    85%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       335     56    83%
source_file/utils.py         13      8    38%
source_file/source.py        83     62    25%
---------------------------------------------
TOTAL                       433    126    71%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 52.58s ========================

[lazebnyi]

Nice!

[bnchrch]

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5073514999
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5073514999
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        83      7    92%
source_file/client.py       335     56    83%
---------------------------------------------
TOTAL                       433     64    85%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       335     56    83%
source_file/utils.py         13      8    38%
source_file/source.py        83     62    25%
---------------------------------------------
TOTAL                       433    126    71%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 53.34s ========================

[bnchrch]

Hey @darynaishchenko just continuing the conversation from slack

You mentioned that source-file-secure is failing! Sorry if I caused that!

If I recall source-file-secure is a very thin wrapper around source-file

can we not just

1. update source-file-secure to use a high strictness level
2. Update its acceptance test settings to mirror source-file

I sure I am likely missing something 😅

[darynaishchenko]

Hey @darynaishchenko just continuing the conversation from slack

You mentioned that source-file-secure is failing! Sorry if I caused that!

If I recall source-file-secure is a very thin wrapper around source-file

can we not just

1. update source-file-secure to use a high strictness level
2. Update its acceptance test settings to mirror source-file

I sure I am likely missing something sweat_smile

yes, the /test command works, but I'm confused by the CI check, or it's ok and we can ignore it?

[bnchrch]

@darynaishchenko I think for this one we can ignore.

[darynaishchenko]

@darynaishchenko I think for this one we can ignore.

thanks!