Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Square: fix build #26298

Merged
merged 11 commits into from
May 19, 2023
Merged

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 19, 2023

What

Fix build for Source Square - expected and actual records mismatch. Root cause - value of the fields updated_at and version was updated in the Items stream.

How

Update CAT config to ignore those fields as this data is volatile and does not hold a valuable info.

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 19, 2023

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/5024619011
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/5024619011
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_square/source.py           4      0   100%
source_square/__init__.py         2      0   100%
source_square/components.py      51      4    92%
-------------------------------------------------
TOTAL                            57      4    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 47 passed, 3 skipped in 1364.09s (0:22:44) ==================

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d davydov-d changed the title Ddavydov/connector health 2023 05 19 🐛 Source Square: fix build May 19, 2023
@davydov-d davydov-d marked this pull request as ready for review May 19, 2023 13:50
@davydov-d davydov-d enabled auto-merge (squash) May 19, 2023 14:32
@davydov-d davydov-d closed this May 19, 2023
auto-merge was automatically disabled May 19, 2023 14:32

Pull request was closed

@davydov-d davydov-d reopened this May 19, 2023
@davydov-d davydov-d merged commit 90de330 into master May 19, 2023
27 of 30 checks passed
@davydov-d davydov-d deleted the ddavydov/connector-health-2023-05-19 branch May 19, 2023 15:12
nguyenaiden pushed a commit that referenced this pull request May 25, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* Connector health: upd CAT config for source-square

* Automated Change

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* Connector health: upd CAT config for source-square

* Automated Change

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants