Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Mixpanel: fix build #26310

Merged
merged 15 commits into from
May 19, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 19, 2023

What

Fix build for the Source Mixpanel

How

Update expected records since they are outdated

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label May 19, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 19, 2023

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/5025729247
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/5025729247
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/utils.py                         8      0   100%
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              57      0   100%
source_mixpanel/streams/cohorts.py              15      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/streams/base.py                 90      3    97%
source_mixpanel/streams/export.py               76      5    93%
source_mixpanel/streams/engage.py               88      6    93%
source_mixpanel/source.py                       79      8    90%
source_mixpanel/streams/annotations.py          16      3    81%
source_mixpanel/streams/cohort_members.py       21      7    67%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          523     43    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 7695.15s (2:08:15) ==================

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d davydov-d changed the title Ddavydov/connector health fix source mixpanel 🐛 Source Mixpanel: fix build May 19, 2023
@davydov-d davydov-d marked this pull request as ready for review May 19, 2023 15:16
@davydov-d davydov-d closed this May 19, 2023
@davydov-d davydov-d reopened this May 19, 2023
@davydov-d davydov-d enabled auto-merge (squash) May 19, 2023 18:33
@davydov-d davydov-d closed this May 19, 2023
auto-merge was automatically disabled May 19, 2023 19:16

Pull request was closed

@davydov-d davydov-d reopened this May 19, 2023
@davydov-d davydov-d enabled auto-merge (squash) May 19, 2023 19:16
@davydov-d davydov-d merged commit 1c8d7aa into master May 19, 2023
23 checks passed
@davydov-d davydov-d deleted the ddavydov/connector-health-fix-source-mixpanel branch May 19, 2023 19:36
nguyenaiden pushed a commit that referenced this pull request May 25, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* source square: fix expected records

* Automated Change

* Automated Change

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* source square: fix expected records

* Automated Change

* Automated Change

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants