Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move qa engine to aibyte-ci #26377

Merged
merged 21 commits into from
May 31, 2023
Merged

Move qa engine to aibyte-ci #26377

merged 21 commits into from
May 31, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented May 22, 2023

What

  1. moves qa-engine to airbyte-ci
  2. updates the project to use poetry
  3. updates the automatic connector release to target airbyte

closes #25510

TODO

  • assign to issue
  • refactor tests
  • test locally
  • add readme

@bnchrch bnchrch force-pushed the bnchrch/move-qa-engine branch 2 times, most recently from 71be6c3 to 950a2ef Compare May 25, 2023 15:01
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bnchrch
❌ Octavia Squidington III


Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bnchrch bnchrch requested a review from a team May 26, 2023 02:06
@bnchrch bnchrch marked this pull request as ready for review May 26, 2023 02:06
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks for the migration

@alafanechere
Copy link
Contributor

Did you try to run the QA engine workflow from your branch?

@alafanechere
Copy link
Contributor

I really love the fact that now enabling a connector for cloud is just changing the metadata.yaml and not opening a PR on another repo 👏

@alafanechere
Copy link
Contributor

@bnchrch can you make sure all the connectors that were explicitly disabled from cloud in the late definitions masks file are correctly disabled according to their metadata file?

@alafanechere
Copy link
Contributor

Moreover, we could explicitly disable connectors for cloud in their metadata now instead of using the INAPPROPRIATE_FOR_CLOUD_USE_CONNECTORS constant list.

@bnchrch bnchrch enabled auto-merge (squash) May 31, 2023 03:44
@bnchrch bnchrch merged commit 5e0e317 into master May 31, 2023
18 of 19 checks passed
@bnchrch bnchrch deleted the bnchrch/move-qa-engine branch May 31, 2023 05:26
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Add change notes

* Add qa-engine poetry

* Port qa_engine code

* Add missing fixture

* Update import

* Update git code

* Delete old qa-engine files

* convert tests

* Add path

* Fix mocks

* Fix test_enable_in_cloud

* Fix metadata path test

* Run formater

* Automated Commit - Formatting Changes

* Update readme

* Remove duplicates

* Remove redundant if

* Add ruamel

* Use ruamel

* Remove safe load

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@sers.noreply.github.com>
Co-authored-by: bnchrch <bnchrch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move qa enginer to airbyte_ci (and update to use registry)
3 participants