-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move qa engine to aibyte-ci #26377
Move qa engine to aibyte-ci #26377
Conversation
71be6c3
to
950a2ef
Compare
Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
87ff3de
to
7cfd39d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Thanks for the migration
Did you try to run the QA engine workflow from your branch? |
I really love the fact that now enabling a connector for cloud is just changing the metadata.yaml and not opening a PR on another repo 👏 |
@bnchrch can you make sure all the connectors that were explicitly disabled from cloud in the late definitions masks file are correctly disabled according to their metadata file? |
Moreover, we could explicitly disable connectors for cloud in their metadata now instead of using the |
* Add change notes * Add qa-engine poetry * Port qa_engine code * Add missing fixture * Update import * Update git code * Delete old qa-engine files * convert tests * Add path * Fix mocks * Fix test_enable_in_cloud * Fix metadata path test * Run formater * Automated Commit - Formatting Changes * Update readme * Remove duplicates * Remove redundant if * Add ruamel * Use ruamel * Remove safe load --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@sers.noreply.github.com> Co-authored-by: bnchrch <bnchrch@users.noreply.github.com>
What
airbyte
closes #25510
TODO