Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Youtube Analytics: migrated to advancedAuth #26420

Conversation

darynaishchenko
Copy link
Collaborator

What

#26250

How

Added advanced_auth to spec.json

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@darynaishchenko darynaishchenko self-assigned this May 23, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/youtube-analytics labels May 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 23, 2023

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/5058569040
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/5058569040
Python tests coverage:

Name                                   Stmts   Miss  Cover
----------------------------------------------------------
source_youtube_analytics/__init__.py       2      0   100%
source_youtube_analytics/source.py       160     14    91%
----------------------------------------------------------
TOTAL                                    162     14    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=========== 39 passed, 1 skipped, 40 warnings in 4709.81s (1:18:29) ============

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 24, 2023

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/5070462713
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/5070462713
Python tests coverage:

Name                                   Stmts   Miss  Cover
----------------------------------------------------------
source_youtube_analytics/__init__.py       2      0   100%
source_youtube_analytics/source.py       160     14    91%
----------------------------------------------------------
TOTAL                                    162     14    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=========== 39 passed, 1 skipped, 40 warnings in 4619.04s (1:16:59) ============

@lazebnyi lazebnyi requested a review from girarda May 25, 2023 15:26
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good, but I haven't tested

@darynaishchenko
Copy link
Collaborator Author

change looks good, but I haven't tested

I have tested it locally, auth was successful

@darynaishchenko darynaishchenko changed the title Source Youtube Analytics: migrated to advancedAuth 🐛Source Youtube Analytics: migrated to advancedAuth May 26, 2023
@darynaishchenko darynaishchenko force-pushed the daryna/source-youtube-analitics/26250-migrate-to-advancedAuth branch from 9ee0a18 to e525cd2 Compare May 26, 2023 11:58
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 26, 2023

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/5090533852
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/5090533852
Python tests coverage:

Name                                   Stmts   Miss  Cover
----------------------------------------------------------
source_youtube_analytics/__init__.py       2      0   100%
source_youtube_analytics/source.py       160     14    91%
----------------------------------------------------------
TOTAL                                    162     14    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=========== 39 passed, 1 skipped, 40 warnings in 4110.21s (1:08:30) ============

@darynaishchenko darynaishchenko merged commit 3443438 into master May 26, 2023
17 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-youtube-analitics/26250-migrate-to-advancedAuth branch May 26, 2023 14:48
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* migrated to advancedAuth

* added changelog

* Automated Change

* removed auth_type

---------

Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/youtube-analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants