New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Source Slack: fix lookback window
value range limits
#26497
π Source Slack: fix lookback window
value range limits
#26497
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! π To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
airbyte-integrations/connectors/source-slack/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-slack
Build PassedTest summary info:
|
/test connector=connectors/source-slack
Build PassedTest summary info:
|
What
Resolving: https://github.com/airbytehq/oncall/issues/2115
The previous fix for
0.1.26
actually didn't work, because ofmin
/max
abbreviations are not supported by JSON Schema, theminimum
/maximum
should be used instead.How
spec.json
withmin
>minimum
,max
>maximum
β User Impact Level β : Non-breaking change
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes