Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the bottleneck datasources and respective catalogs and updated description for the harness #26503

Merged
merged 2 commits into from
May 24, 2023

Conversation

ryankfu
Copy link
Contributor

@ryankfu ryankfu commented May 24, 2023

What

Merges the perf-harness bottleneck datasets that were used in Hack Week branch to master

How

Updates the description so someone who is using the destination performance harness is able to know which datasets are available

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@ryankfu ryankfu requested a review from rodireich May 24, 2023 16:46
@ryankfu ryankfu marked this pull request as ready for review May 24, 2023 16:55
@ryankfu ryankfu enabled auto-merge (squash) May 24, 2023 16:55
@ryankfu
Copy link
Contributor Author

ryankfu commented May 24, 2023

/approve-and-merge reason="not in critical path and build seems to be non-mergable after an Automated Commit"

@octavia-approvington
Copy link
Contributor

All in!!
all in baby

@octavia-approvington octavia-approvington merged commit c87ffb3 into master May 24, 2023
6 checks passed
@octavia-approvington octavia-approvington deleted the ryan/update-perf-harness-datasource branch May 24, 2023 17:17
@ryankfu
Copy link
Contributor Author

ryankfu commented May 24, 2023

cc: @alafanechere since the last time I spoke with Ben he mentioned this should be on your radar. The issue is whenever an Automated Change happens it doesn't rebuild the entire build tests and it prevents the PR from being merged

@alafanechere
Copy link
Contributor

@ryankfu I think @bnchrch is actively working on it. In case it's bloking you feel free to close and reopen PRs, it's retrigerring things.

nguyenaiden pushed a commit that referenced this pull request May 25, 2023
…escription for the harness (#26503)

* Adds the bottleneck datasources and respective catalogs and updated description for the harness

* Automated Commit - Formatting Changes

---------

Co-authored-by: ryankfu <ryankfu@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…escription for the harness (airbytehq#26503)

* Adds the bottleneck datasources and respective catalogs and updated description for the harness

* Automated Commit - Formatting Changes

---------

Co-authored-by: ryankfu <ryankfu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants