-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectors-ci: pass PR id to airbyte-ci #26504
connectors-ci: pass PR id to airbyte-ci #26504
Conversation
🔥 source-pokeapi test report 🔥⏲️ Total pipeline duration: 115 seconds
Please note that tests are only run on PR ready for review. airbyte-ci connectors --name=source-pokeapi test |
Notes from Retro:
|
source-pokeapi test report (commit
|
Step | Result |
---|---|
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-pokeapi docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-pokeapi test
source-openweather test report (commit
|
Step | Result |
---|---|
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-openweather docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-openweather test
@evantahler I did the following improvements:
I believe we should not update comments and create one comment per test run as it helps tracking which commit led to different test results. And it's tedious to update a comment because our jobs are stateless and I can keep the comment ID around to update it on a different pipeline run. |
#- "airbyte-integrations/connectors/**" | ||
#- ".github/workflows/connector_integration_test_single_dagger.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to current infra problems it's not safe to enable the automated test pipeline right now - concurrent jobs are blocking each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alafanechere if im reading this right then this workflow will run on "all" opened/ready for review PRs
Do we not want to keep these path filters so it runs on "all connector related" prs instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pipeline will eventually run on all PRs to make the required check pass...
- opened | ||
- synchronize | ||
- ready_for_review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline will run when:
- the pr is opened
- when a commit is pushed to the pr
- when the pr is made ready for review
But the tests will run only if the PR is not in draft mode thank to this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. Other than that LGTM!
#- "airbyte-integrations/connectors/**" | ||
#- ".github/workflows/connector_integration_test_single_dagger.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alafanechere if im reading this right then this workflow will run on "all" opened/ready for review PRs
Do we not want to keep these path filters so it runs on "all connector related" prs instead?
@bnchrch If we want to create a required PR check it'll have to run on all PRs... airbyte/tools/ci_connector_ops/ci_connector_ops/pipelines/commands/groups/connectors.py Lines 156 to 158 in 14c854e
|
What
1/2 to complete #24322
Closes #25279
We want to get the pull request id (aka pull request number) in the CI context to:
How
airbyte-ci
as an env var🚨 User Impact 🚨
PRODUCTION
env var to True.