Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: mention custom objects in hubspot docs #26507

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

sherifnada
Copy link
Contributor

No description provided.

@sherifnada sherifnada marked this pull request as ready for review May 24, 2023 17:26
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 24, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sherifnada I wasn't aware of the need of this message and the additional steps.
To clarify any new Hubspot stream which needs additional scope we must add this info?

@sherifnada
Copy link
Contributor Author

@marcosmarxm yes if we add a new stream which requires new oauth scopes the user needs to take those steps

@sherifnada sherifnada merged commit 63f7fc0 into master May 24, 2023
20 checks passed
@sherifnada sherifnada deleted the sherifnada-patch-1 branch May 24, 2023 17:40
@nataliekwong
Copy link
Contributor

Note if the user is not using OAuth and instead a private key, they'll need to instead go into Hubspot and update the scopes the key has access to instead (rather than reauthenticating OAuth app permissions).

@sherifnada
Copy link
Contributor Author

@nataliekwong good call, fixed that plus other things in #26533

marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants