Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectors-ci: re-upload spec if image exists + fix pre-release #26604

Merged
merged 4 commits into from
May 25, 2023
Merged

connectors-ci: re-upload spec if image exists + fix pre-release #26604

merged 4 commits into from
May 25, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented May 25, 2023 •
edited

What

Bugs:

  • the metatada upload step can't be instantiated with empty secrets to connect to GCS buckets.On pre-release the secret are set to none as no metadata upload happens.
  • When a connector got docker pushed but the rest of the pipeline fail we can end up in a situation where the image exists on DockerHub but the spec file was not uploaded.

How

Fix:

  • Only instantiate the metadata upload step when we're not on pre-release.
  • Alway reupload spec file if image exists, in case it was not written in a previously failed pipeline.

@alafanechere alafanechere requested a review from bnchrch May 25, 2023 18:14
@alafanechere alafanechere changed the title connectors-ci: hotfix pre-release connectors-ci: re-upload spec if image exists + fix pre-release May 25, 2023
@alafanechere alafanechere merged commit 42f3d45 into master May 25, 2023
4 checks passed
@alafanechere alafanechere deleted the augustin/connectors-ci/hotfix-publish-prerelease branch May 25, 2023 19:53
@alafanechere alafanechere mentioned this pull request May 30, 2023
Closed
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@alafanechere @marcosmarxm
connectors-ci: re-upload spec if image exists + fix pre-release (airb…
c826986 
…ytehq#26604)

* connectors-ci: fix pre-release

* fix edge case

* Automated Change

---------

Co-authored-by: alafanechere <alafanechere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnchrch bnchrch bnchrch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alafanechere @bnchrch