Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove duplicate version declaration for source-gitlab #26631

Merged

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented May 25, 2023

What

Removes the previous docker version which was forgotten:
01b1673

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bnchrch
Copy link
Contributor Author

bnchrch commented May 25, 2023

/test connector="connectors/source-gitlab"

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5085137915
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/5085137915
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_gitlab/__init__.py       2      0   100%
source_gitlab/source.py        61      3    95%
source_gitlab/streams.py      281     15    95%
-----------------------------------------------
TOTAL                         344     18    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 43 passed, 2 skipped in 543.94s (0:09:03) ===================

@bnchrch bnchrch force-pushed the bnchrch/fix/remove-duplicate-docker-version branch from b63ad82 to f673920 Compare May 25, 2023 22:24
@bnchrch
Copy link
Contributor Author

bnchrch commented May 25, 2023

/approve-and-merge reason="remove version"

@octavia-approvington
Copy link
Contributor

All in!!
all in baby

@octavia-approvington octavia-approvington merged commit ccc701f into master May 25, 2023
21 of 22 checks passed
@octavia-approvington octavia-approvington deleted the bnchrch/fix/remove-duplicate-docker-version branch May 25, 2023 23:01
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@sers.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants