connectors-ci: publish strict-encrypt first #26644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed the sorts works with this pre-release workflow. |
bnchrch
reviewed
May 26, 2023
| they will be sorted first with our reverse sort below. | ||
| """ | ||
|
|
||
| return sorted(contexts, key=lambda context: context.connector.technical_name, reverse=True) |
There was a problem hiding this comment.
So I like this!
But, I think concurrency might still bite us
i.e. if we have concurrency set to 5 we might build source-file and source-file-secure at the same time
Perhaps we want the sort to pull the strict-encrypt variants to the start and their counter parts to the end of the list?
Or at the conncurreny level we explicitly try and build all strict encrypts in one block before anything else?
There was a problem hiding this comment.
On publish concurrency is forced to 1 for safety/stability.
bnchrch
approved these changes
May 30, 2023
alafanechere
deleted the
augustin/connectors-ci/publish-strict-encrypt-first
branch
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #26635
The metadata upload step on publish checks if the the connectors referenced in the metadata file are already published to DockerHub. Non strict-encrypt variant reference the strict-encrypt variant in their metadata file for cloud.
So if we publish the non strict-encrypt variant first, the metadata upload will fail if the strict-encrypt variant is not published yet.
As strict-encrypt variant are often modified in the same PR as the non strict-encrypt variant, we want to publish them first.
How
Hacky approach: as connector names with -strict-encrypt/secure prefix are longer, they will be sorted first with a reverse sort below.