Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Close.com: fix expected records #26654

Merged
merged 2 commits into from
May 29, 2023
Merged

Source Close.com: fix expected records #26654

merged 2 commits into from
May 29, 2023

Conversation

roman-yermilov-gl
Copy link
Collaborator

What

Expected records do not match. visibility_mode field was added

How

Update expected records and schema

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023 •
edited by roman-yermilov-gl

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl self-assigned this May 26, 2023
@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented May 26, 2023 •
edited by github-actions bot

/test connector=connectors/source-close-com

🕑 connectors/source-close-com https://github.com/airbytehq/airbyte/actions/runs/5090121502
✅ connectors/source-close-com https://github.com/airbytehq/airbyte/actions/runs/5090121502
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 39 passed, 1 skipped in 368.81s (0:06:08) ===================

lazebnyi
lazebnyi approved these changes May 29, 2023
View reviewed changes
airbyte-integrations/connectors/source-close-com/integration_tests/expected_records.jsonl
@@ -74,7 +74,7 @@
{"stream": "zoom_connected_accounts", "data": {"smtp": null, "is_imap_archive_sync_enabled": true, "default_identity": {"name": "Airbyte Team", "email": "integration-test@airbyte.io"}, "id": "emailacct_pSuPSwRBjmzoTYudYJRn9ENpaR3RAaRp7K2jJ8syPsp", "available_features": [], "latest_send_error": null, "user_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "lead_suggestions_updated_at": null, "imap": null, "send_status": null, "identities": [], "email_receive_status": null, "enabled_features": [], "_type": "zoom", "receive_attempts_count": 0, "receive_status": null, "calendar_receive_status": null, "date_created": "2022-11-08T13:13:08.795000+00:00", "organization_id": "orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi", "latest_receive_error": null, "email": "integration-test@airbyte.io", "zoom_account_plan": null}, "emitted_at": 1683623888406}
{"stream": "email_sequences", "data": {"allow_manual_enrollment": true, "created_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "date_created": "2022-11-08T12:07:06.184401", "date_updated": "2022-11-08T12:07:06.184405", "id": "seq_17gkOeJEV1QPdPaOMJ9mTX", "name": "Sequence 1", "organization_id": "orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi", "schedule_id": "sched_1eL83fHJodv0OtoibuJFAw", "status": "active", "steps": [{"created_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "date_created": "2022-11-08T12:07:06.191662", "date_updated": "2022-11-08T12:07:06.191665", "delay": 0, "email_template_id": "tmpl_qbI7mmvEPJla4qdCeBygtzgZ7twup69mdEr2CEVNHIM", "id": "seqstep_5lFdCIwj4qVpdVMH3K26iQ", "required": true, "sms_template_id": null, "step_allowed_delay": null, "step_type": "email", "threading": "old_thread", "updated_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}, {"created_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "date_created": "2022-11-08T12:07:06.191692", "date_updated": "2022-11-08T12:07:06.191693", "delay": 259200, "email_template_id": null, "id": "seqstep_4YVJ2uoVccNHYG95qvwDQw", "required": false, "sms_template_id": null, "step_allowed_delay": 3600, "step_type": "call", "threading": null, "updated_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}], "timezone": "Europe/Kiev", "trigger_query": null, "updated_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}, "emitted_at": 1683885150263}
{"stream": "email_sequences", "data": {"allow_manual_enrollment": true, "created_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "date_created": "2022-11-08T12:07:48.571475", "date_updated": "2022-11-08T12:07:48.571481", "id": "seq_7gEZ4ByvvLv1rI6szKolhR", "name": "Sequence 2", "organization_id": "orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi", "schedule_id": "sched_3MvlPuSqL0NGJyY95MBMpF", "status": "active", "steps": [{"created_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "date_created": "2022-11-08T12:07:48.623996", "date_updated": "2022-11-08T12:07:48.624000", "delay": 3600, "email_template_id": "tmpl_Cilxd4yapDRweK6caKOTGzSHqyP9ddiEz4G0DLg0nwt", "id": "seqstep_71ELVa12hUsLg2ba3K74Yq", "required": true, "sms_template_id": null, "step_allowed_delay": null, "step_type": "email", "threading": "old_thread", "updated_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}], "timezone": "Europe/Kiev", "trigger_query": null, "updated_by_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}, "emitted_at": 1683885150272}
{"stream": "dialer", "data": {"caller_id": "", "date_created": "2022-11-08T14:27:23.185019", "date_updated": "2022-11-08T14:27:23.309015", "id": "dial_5qE6KYskn4PfT6oQLTe8ez", "is_user_dependent": false, "music_preference": "tone1", "organization_id": "orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi", "ring_mode": "more-voicemails", "source_type": "saved-search", "source_value": "save_vL2ENUTpFhqrYHf97tm61Y9Sh6QughnuMURuIH4VDCC", "status": "inactive", "target_type": "lead", "type": "power", "user_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "users": [{"is_active": false, "state": "inactive", "user_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}]}, "emitted_at": 1683623891380}
{"stream": "dialer", "data": {"caller_id": "", "date_created": "2022-11-08T14:27:23.185019", "date_updated": "2022-11-08T14:27:23.309015", "id": "dial_5qE6KYskn4PfT6oQLTe8ez", "is_user_dependent": false, "music_preference": "tone1", "organization_id": "orga_ya3w9oMjeLtWe7zFGZr63Dz8ruBbjybG0EIUdUXaESi", "ring_mode": "more-voicemails", "source_type": "saved-search", "source_value": "save_vL2ENUTpFhqrYHf97tm61Y9Sh6QughnuMURuIH4VDCC", "status": "inactive", "target_type": "lead", "type": "power", "user_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg", "users": [{"is_active": false, "state": "inactive", "user_id": "user_SOwJFVMqtgZCL6QrMDLujSXbQabQnNfOwjFX1mdOulg"}],"visibility_mode":"all"}, "emitted_at": 1683623891380}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write what exactly changed in expected records in PR description.

@roman-yermilov-gl roman-yermilov-gl merged commit 79a122d into master May 29, 2023
22 of 23 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-close-com-health-check-fix-expected-records branch May 29, 2023 15:32
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@roman-yermilov-gl @marcosmarxm
Source Close.com: fix expected records (airbytehq#26654)
3e2d3bf 
* Source Close.com: fix expected records

* Source Close.com: add `visibility_mode` fields to dialer schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues connectors/source/close-com
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roman-yermilov-gl @lazebnyi @octavia-squidington-iii