Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Instagram: migrate to advanced auth #26656

Merged

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 26, 2023

What

#26237

How

Replace authSpecification in spec with advancedAuth

this change can not be manually tested on localhost because the Oauth app does not contain localhost in allowed redirect URLs

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram labels May 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 26, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5090606431

@davydov-d
Copy link
Collaborator Author

davydov-d commented May 26, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5094140500
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/5094140500
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      215     20    91%
source_instagram/api.py           61      9    85%
--------------------------------------------------
TOTAL                            345     32    91%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           61      7    89%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      215     99    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            345    139    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 38 passed, 2 skipped in 268.13s (0:04:28) ===================

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But need tested with pre-release tag.

@davydov-d davydov-d merged commit e9f57c5 into master May 29, 2023
26 of 27 checks passed
@davydov-d davydov-d deleted the ddavydov/#26237-source-instagram-migrate-to-advancedAuth branch May 29, 2023 18:43
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* airbytehq#26237 source instagram - migrate to advancedAuth

* source instagram: upd changelog

* airbytehq#26237: source instagram: upd exepcted spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants