Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Twilio: fix expected records and docker image tag #26675

Conversation

roman-yermilov-gl
Copy link
Collaborator

@roman-yermilov-gl roman-yermilov-gl commented May 26, 2023

What

executions steram became empty for some reason. After some manipulations a reocrd become present in response. There is also new field subresource_uris in incoming_phone_numbers stream. Docker image tag was not updated.

How

Made new execution record, updated expected records and schema for incoming_phone_numbers stream. Updated docker image tag

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented May 26, 2023

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/5092706349
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/5092706349
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 42 passed, 1 skipped in 2110.62s (0:35:10) ==================

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented May 29, 2023

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/5111200524
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/5111200524
🐛 https://gradle.com/s/4a7r4eqlzegtu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream usage...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
============= 1 failed, 41 passed, 1 skipped in 1962.56s (0:32:42) =============

@roman-yermilov-gl roman-yermilov-gl changed the title Ryermilov/source twilio health check fix expected records Source Twilio: fix expected records and docker image tag May 29, 2023
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to failed action to PR description.

@roman-yermilov-gl
Copy link
Collaborator Author

roman-yermilov-gl commented May 29, 2023

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/5115195189
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/5115195189
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_twilio/auth.py           8      0   100%
source_twilio/__init__.py       2      0   100%
source_twilio/source.py        28      1    96%
source_twilio/streams.py      338     34    90%
-----------------------------------------------
TOTAL                         376     35    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 42 passed, 1 skipped in 1958.51s (0:32:38) ==================

@roman-yermilov-gl roman-yermilov-gl merged commit 458b5ab into master May 29, 2023
22 of 23 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-twilio-health-check-fix-expected-records branch May 29, 2023 22:17
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…6675)

* Source Twilio: fix acceptance tests

* Source Twilio: fix acceptance tests

* Source Twilio: fix dockerfile imagetag version

* Update expected_records.jsonl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants