-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-architecture normalization build (local) #26677
Conversation
When building and testing normalization locally, we need to force the base images to match the local host OS. This is not a problem when publishing the connectors as `airbyte-ci`/dagger handles this for us
Affected Connector ReportNOTE
|
Connector | Version | Changelog | Publish |
---|
- See "Actionable Items" below for how to resolve warnings and errors.
❌ Destinations (15)
Connector | Version | Changelog | Publish |
---|---|---|---|
destination-bigquery |
1.4.4 |
✅ | ✅ |
destination-bigquery-denormalized |
1.4.1 |
✅ | ✅ |
destination-clickhouse |
0.2.3 |
✅ | ✅ |
destination-clickhouse-strict-encrypt |
0.2.3 |
🔵 (ignored) |
🔵 (ignored) |
destination-mssql |
0.1.23 |
✅ | ✅ |
destination-mssql-strict-encrypt |
0.1.23 |
🔵 (ignored) |
🔵 (ignored) |
destination-mysql |
0.1.20 |
✅ | ✅ |
destination-mysql-strict-encrypt |
❌ 0.1.21 (mismatch: 0.1.20 ) |
🔵 (ignored) |
🔵 (ignored) |
destination-oracle |
0.1.19 |
✅ | ✅ |
destination-oracle-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
destination-postgres |
0.3.27 |
✅ | ✅ |
destination-postgres-strict-encrypt |
0.3.27 |
🔵 (ignored) |
🔵 (ignored) |
destination-redshift |
0.4.8 |
✅ | ✅ |
destination-snowflake |
1.0.4 |
✅ | ✅ |
destination-tidb |
0.1.1 |
✅ | ❌ (diff seed version) |
- See "Actionable Items" below for how to resolve warnings and errors.
👀 Other Modules (1)
- base-normalization
Actionable Items
(click to expand)
Category | Status | Actionable Item |
---|---|---|
Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
Publish | ⚠ not in seed |
The connector is not in the cloud or oss registry, so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that you have added a metadata.yaml file and the expected registries are enabled. |
There may also be a slight speed improvement on building these images now that they aren't emulating some other arch too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. this has no impact on prod, right? because /publish
doesn't go through this path anymore
I think this should be OK for 2 reasons:
|
…"" This reverts commit a89d5bc.
This reverts commit 75240b0.
* Multi-architecture normalization build (local) When building and testing normalization locally, we need to force the base images to match the local host OS. This is not a problem when publishing the connectors as `airbyte-ci`/dagger handles this for us * Update build.gradle
@evantahler was this not detecting the correct local arch before this change? I ran into this because I was attempting to build an amd image on my arm machine. I was doing so by setting |
no... because the base image we use is so old, they only ever published AMD images... so any image built on it remains AMD unless you do something drastic... like this! Anyway, all of this is going away soon so 🤷 |
You can update the changes if you want to look at the ENV |
When building and testing normalization locally, we need to force the base images to match the local host OS.
This is not a problem when publishing the connectors as
airbyte-ci
/dagger handles this for us